Skip to content

Commit 6795a24

Browse files
committed
Do not expose association relation in the API doc [ci skip]
`Association` and `AssociationRelation` are implementation details, I do not want to expose those internals in the API doc, and people basically should not rely on those internals. https://github.com/rails/rails/blob/8544c9c23687964ab754c06a7745215a5369a4e0/activerecord/lib/active_record/associations/association.rb https://github.com/rails/rails/blob/8544c9c23687964ab754c06a7745215a5369a4e0/activerecord/lib/active_record/association_relation.rb As a side note, `record.association(:name)` is also private API. https://github.com/rails/rails/blob/8544c9c23687964ab754c06a7745215a5369a4e0/activerecord/lib/active_record/associations.rb#L228-L240
1 parent 8544c9c commit 6795a24

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

activerecord/lib/active_record/association_relation.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# frozen_string_literal: true
22

33
module ActiveRecord
4-
class AssociationRelation < Relation
4+
class AssociationRelation < Relation # :nodoc:
55
def initialize(klass, association, **)
66
super(klass)
77
@association = association

activerecord/lib/active_record/associations/collection_proxy.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -920,7 +920,7 @@ def include?(record)
920920
!!@association.include?(record)
921921
end
922922

923-
def proxy_association
923+
def proxy_association # :nodoc:
924924
@association
925925
end
926926

0 commit comments

Comments
 (0)