More less and lazy allocation for assign_attributes and _assign_attributes

kamipo · kamipo · commit 79ba0694cbb6 · 2020-02-25T16:58:00.000+09:00
https://gist.github.com/kamipo/296b9dd97f690d7960fdfe8de3ca08c7 Before: ``` ================================= All symbols ================================== Warming up -------------------------------------- assign_attributes 4.425k i/100ms Calculating ------------------------------------- assign_attributes 44.983k (± 2.8%) i/s - 225.675k in 5.020906s ==================================== Mixed ===================================== Warming up -------------------------------------- assign_attributes 4.546k i/100ms Calculating ------------------------------------- assign_attributes 46.103k (± 5.2%) i/s - 231.846k in 5.046489s ================================= All strings ================================== Warming up -------------------------------------- assign_attributes 4.511k i/100ms Calculating ------------------------------------- assign_attributes 47.931k (± 7.4%) i/s - 239.083k in 5.023971s ``` After: ``` ================================= All symbols ================================== Warming up -------------------------------------- assign_attributes 4.831k i/100ms Calculating ------------------------------------- assign_attributes 48.206k (± 8.5%) i/s - 241.550k in 5.058372s ==================================== Mixed ===================================== Warming up -------------------------------------- assign_attributes 4.960k i/100ms Calculating ------------------------------------- assign_attributes 50.628k (± 3.5%) i/s - 252.960k in 5.002779s ================================= All strings ================================== Warming up -------------------------------------- assign_attributes 5.006k i/100ms Calculating ------------------------------------- assign_attributes 52.242k (± 5.5%) i/s - 260.312k in 5.001695s ```
diff --git a/activerecord/lib/active_record/attribute_assignment.rb b/activerecord/lib/active_record/attribute_assignment.rb
@@ -6,30 +6,24 @@ module ActiveRecord
   module AttributeAssignment
     include ActiveModel::AttributeAssignment
 
-    def assign_attributes(attributes)
-      super(attributes.dup)
-    end
-
-    alias attributes= assign_attributes
-
     private
       def _assign_attributes(attributes)
-        multi_parameter_attributes  = {}
-        nested_parameter_attributes = {}
+        multi_parameter_attributes = nested_parameter_attributes = nil
 
         attributes.each do |k, v|
           key = k.to_s
 
           if key.include?("(")
-            multi_parameter_attributes[key] = attributes.delete(k)
+            (multi_parameter_attributes ||= {})[key] = v
           elsif v.is_a?(Hash)
-            nested_parameter_attributes[key] = attributes.delete(k)
+            (nested_parameter_attributes ||= {})[key] = v
+          else
+            _assign_attribute(key, v)
           end
         end
-        super(attributes)
 
-        assign_nested_parameter_attributes(nested_parameter_attributes) unless nested_parameter_attributes.empty?
-        assign_multiparameter_attributes(multi_parameter_attributes) unless multi_parameter_attributes.empty?
+        assign_nested_parameter_attributes(nested_parameter_attributes) if nested_parameter_attributes
+        assign_multiparameter_attributes(multi_parameter_attributes) if multi_parameter_attributes
       end
 
       # Assign any deferred nested attributes after the base attributes have been set.
