Ensure that singular association should execute limited query

kamipo · kamipo · commit ba4e68f577ef · 2018-11-28T01:48:33.000+09:00
diff --git a/activerecord/test/cases/associations/belongs_to_associations_test.rb b/activerecord/test/cases/associations/belongs_to_associations_test.rb
@@ -32,9 +32,12 @@ class BelongsToAssociationsTest < ActiveRecord::TestCase
            :posts, :tags, :taggings, :comments, :sponsors, :members
 
   def test_belongs_to
-    firm = Client.find(3).firm
-    assert_not_nil firm
-    assert_equal companies(:first_firm).name, firm.name
+    client = Client.find(3)
+    assert_sql(/LIMIT|ROWNUM <=|FETCH FIRST/) do
+      firm = client.firm
+      assert_not_nil firm
+      assert_equal companies(:first_firm).name, firm.name
+    end
   end
 
   def test_assigning_belongs_to_on_destroyed_object
diff --git a/activerecord/test/cases/associations/has_one_associations_test.rb b/activerecord/test/cases/associations/has_one_associations_test.rb
@@ -22,8 +22,12 @@ def setup
   end
 
   def test_has_one
-    assert_equal companies(:first_firm).account, Account.find(1)
-    assert_equal Account.find(1).credit_limit, companies(:first_firm).account.credit_limit
+    firm = companies(:first_firm)
+    assert_sql(/LIMIT|ROWNUM <=|FETCH FIRST/) do
+      account = firm.account
+      assert_equal account, Account.find(1)
+      assert_equal Account.find(1).credit_limit, account.credit_limit
+    end
   end
 
   def test_has_one_does_not_use_order_by
