Merge pull request rails#34522 from yahonda/sqlite3_returns_primary_key_in_expected_order

kamipo · web-flow · commit bbe1a9bcbacb · 2018-11-26T10:41:16.000+09:00
SQLite 3.7.16+ returns the order of the primary key columns
diff --git a/activerecord/test/cases/primary_keys_test.rb b/activerecord/test/cases/primary_keys_test.rb
@@ -354,7 +354,6 @@ def test_composite_primary_key_with_reserved_words
   end
 
   def test_composite_primary_key_out_of_order
-    skip if current_adapter?(:SQLite3Adapter)
     assert_equal ["code", "region"], @connection.primary_keys("barcodes_reverse")
   end
 
@@ -376,7 +375,6 @@ def test_collectly_dump_composite_primary_key
   end
 
   def test_dumping_composite_primary_key_out_of_order
-    skip if current_adapter?(:SQLite3Adapter)
     schema = dump_table_schema "barcodes_reverse"
     assert_match %r{create_table "barcodes_reverse", primary_key: \["code", "region"\]}, schema
   end
