Merge pull request rails#38928 from jonathanhefner/fix-limit-count-test-non-determinism

kamipo · web-flow · commit bfbf696ed82d · 2020-04-12T14:50:04.000+09:00
Fix random CI fail due to non-deterministic order
diff --git a/activerecord/test/cases/calculations_test.rb b/activerecord/test/cases/calculations_test.rb
@@ -169,14 +169,14 @@ def test_should_limit_calculation_with_offset
   end
 
   def test_limit_should_apply_before_count
-    accounts = Account.limit(4)
+    accounts = Account.order(:id).limit(4)
 
     assert_equal 3, accounts.count(:firm_id)
     assert_equal 3, accounts.select(:firm_id).count
   end
 
   def test_limit_should_apply_before_count_arel_attribute
-    accounts = Account.limit(4)
+    accounts = Account.order(:id).limit(4)
 
     firm_id_attribute = Account.arel_table[:firm_id]
     assert_equal 3, accounts.count(firm_id_attribute)
