Merge pull request rails#38914 from jasonhl/less-path-info

rafaelfranca · web-flow · commit c7620bb9dee7 · 2020-04-13T13:10:26.000-04:00
Reduce calls to get path info when finding routes
diff --git a/actionpack/lib/action_dispatch/journey/router.rb b/actionpack/lib/action_dispatch/journey/router.rb
@@ -106,8 +106,9 @@ def filter_routes(path)
         end
 
         def find_routes(req)
-          routes = filter_routes(req.path_info).concat custom_routes.find_all { |r|
-            r.path.match?(req.path_info)
+          path_info = req.path_info
+          routes = filter_routes(path_info).concat custom_routes.find_all { |r|
+            r.path.match?(path_info)
           }
 
           if req.head?
@@ -119,7 +120,7 @@ def find_routes(req)
           routes.sort_by!(&:precedence)
 
           routes.map! { |r|
-            match_data = r.path.match(req.path_info)
+            match_data = r.path.match(path_info)
             path_parameters = {}
             match_data.names.each_with_index { |name, i|
               val = match_data[i + 1]
