Remove hash deconstruction

tenderlove · tenderlove · commit eb2aedb5a47e · 2020-02-24T17:08:02.000-08:00
I don't think this hash deconstruction buys us much in terms of
readability.  We only need two parameters, the rest are ignored, and on
top of that we have to allocate a hash.  Convert to positional
parameters instead.
diff --git a/activerecord/lib/active_record/railties/collection_cache_association_loading.rb b/activerecord/lib/active_record/railties/collection_cache_association_loading.rb
@@ -8,12 +8,12 @@ def setup(context, options, as, block)
 
         return super unless options[:cached]
 
-        @relation = relation_from_options(**options)
+        @relation = relation_from_options(options[:partial], options[:collection])
 
         super
       end
 
-      def relation_from_options(cached: nil, partial: nil, collection: nil, **_)
+      def relation_from_options(partial, collection)
         relation = partial if partial.is_a?(ActiveRecord::Relation)
         relation ||= collection if collection.is_a?(ActiveRecord::Relation)
 
