Update no-production-logging.js

walaura · walaura · commit 46e17a970066 · 2019-12-05T14:51:43.000Z
diff --git a/scripts/eslint-rules/no-production-logging.js b/scripts/eslint-rules/no-production-logging.js
@@ -23,31 +23,35 @@ module.exports = function(context) {
     }
   }
 
-  const isLoggerNode = name =>
+  function report(node) {
+    context.report({
+      node: node,
+      message: 'Wrap {{identifier}} in a `if (__DEV__)` check',
+      data: {
+        identifier: node.callee.name,
+      },
+      fix: function(fixer) {
+        return [
+          fixer.insertTextBefore(node.parent, 'if (__DEV__) {'),
+          fixer.insertTextAfter(node.parent, '}'),
+        ];
+      },
+    });
+  }
+
+  const isLoggerFunctionName = name =>
     ['warning', 'warningWithoutStack'].includes(name);
 
   return {
     meta: {
       fixable: 'code',
     },
-    CallExpression: node => {
-      if (!isLoggerNode(node.callee.name)) {
+    CallExpression: function(node) {
+      if (!isLoggerFunctionName(node.callee.name)) {
         return;
       }
       if (!hasIfInParents(node)) {
-        context.report({
-          node: node,
-          message: 'Wrap {{identifier}} in a `if (__DEV__)` check',
-          data: {
-            identifier: node.callee.name,
-          },
-          fix: function(fixer) {
-            return [
-              fixer.insertTextBefore(node.parent, 'if (__DEV__) {'),
-              fixer.insertTextAfter(node.parent, '}'),
-            ];
-          },
-        });
+        report(node);
       }
     },
   };
