wip: compiler should default to v3 behavior

yyx990803 · yyx990803 · commit c5c304af144b · 2021-04-17T15:55:14.000-04:00
diff --git a/packages/compiler-core/__tests__/transforms/vIf.spec.ts b/packages/compiler-core/__tests__/transforms/vIf.spec.ts
@@ -306,6 +306,7 @@ describe('compiler: v-if', () => {
           code: ErrorCodes.X_V_IF_SAME_KEY
         }
       ])
+      expect('unnecessary key usage on v-if').toHaveBeenWarned()
     })
   })
 
diff --git a/packages/compiler-core/src/compat/compatConfig.ts b/packages/compiler-core/src/compat/compatConfig.ts
@@ -96,13 +96,18 @@ const deprecationData: Record<CompilerDeprecationTypes, DeprecationData> = {
 }
 
 function getCompatValue(
-  key: CompilerDeprecationTypes,
+  key: CompilerDeprecationTypes | 'MODE',
   context: ParserContext | TransformContext
 ) {
   const config = (context as ParserContext).options
     ? (context as ParserContext).options.compatConfig
     : (context as TransformContext).compatConfig
-  return config && config[key]
+  const value = config && config[key]
+  if (key === 'MODE') {
+    return value || 3 // compiler defaults to v3 behavior
+  } else {
+    return value
+  }
 }
 
 export function checkCompatEnabled(
@@ -111,9 +116,11 @@ export function checkCompatEnabled(
   loc: SourceLocation | null,
   ...args: any[]
 ): boolean {
+  const mode = getCompatValue('MODE', context)
   const value = getCompatValue(key, context)
-  // during tests, only enable when value is explicitly true
-  const enabled = __TEST__ ? value === true : value !== false
+  // in v3 mode, only enable if explicitly set to true
+  // otherwise enable for any non-false value
+  const enabled = mode === 3 ? value === true : value !== false
   if (__DEV__ && enabled) {
     warnDeprecation(key, context, loc, ...args)
   }
diff --git a/packages/compiler-core/src/errors.ts b/packages/compiler-core/src/errors.ts
@@ -14,7 +14,7 @@ export function defaultOnError(error: CompilerError) {
 }
 
 export function defaultOnWarn(msg: CompilerError) {
-  __DEV__ && console.warn(`[Vue warn]`, msg.message)
+  __DEV__ && console.warn(`[Vue warn] ${msg.message}`)
 }
 
 export function createCompilerError<T extends number>(

Original file line number	Diff line number	Diff line change
`@@ -306,6 +306,7 @@ describe('compiler: v-if', () => {`
`306`	`306`	`code: ErrorCodes.X_V_IF_SAME_KEY`
`307`	`307`	`}`
`308`	`308`	`])`
	`309`	`+ expect('unnecessary key usage on v-if').toHaveBeenWarned()`
`309`	`310`	`})`
`310`	`311`	`})`
`311`	`312`
Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@ export function defaultOnError(error: CompilerError) {`
`14`	`14`	`}`
`15`	`15`
`16`	`16`	`export function defaultOnWarn(msg: CompilerError) {`
`17`		- __DEV__ && console.warn(`[Vue warn]`, msg.message)
	`17`	+ __DEV__ && console.warn(`[Vue warn] ${msg.message}`)
`18`	`18`	`}`
`19`	`19`
`20`	`20`	`export function createCompilerError<T extends number>(`