chore(types): improve of type assertion (vuejs#4141)

webfansplz · web-flow · commit df0ce2183627 · 2021-07-19T10:32:07.000-04:00
diff --git a/packages/compiler-core/src/ast.ts b/packages/compiler-core/src/ast.ts
@@ -692,7 +692,7 @@ export function createCallExpression<T extends CallExpression['callee']>(
     loc,
     callee,
     arguments: args
-  } as any
+  } as InferCodegenNodeType<T>
 }
 
 export function createFunctionExpression(
diff --git a/packages/compiler-core/src/errors.ts b/packages/compiler-core/src/errors.ts
@@ -17,20 +17,24 @@ export function defaultOnWarn(msg: CompilerError) {
   __DEV__ && console.warn(`[Vue warn] ${msg.message}`)
 }
 
+type InferCompilerError<T> = T extends ErrorCodes
+  ? CoreCompilerError
+  : CompilerError
+
 export function createCompilerError<T extends number>(
   code: T,
   loc?: SourceLocation,
   messages?: { [code: number]: string },
   additionalMessage?: string
-): T extends ErrorCodes ? CoreCompilerError : CompilerError {
+): InferCompilerError<T> {
   const msg =
     __DEV__ || !__BROWSER__
       ? (messages || errorMessages)[code] + (additionalMessage || ``)
       : code
-  const error = new SyntaxError(String(msg)) as CompilerError
+  const error = new SyntaxError(String(msg)) as InferCompilerError<T>
   error.code = code
   error.loc = loc
-  return error as any
+  return error
 }
 
 export const enum ErrorCodes {

Original file line number	Diff line number	Diff line change
`@@ -692,7 +692,7 @@ export function createCallExpression<T extends CallExpression['callee']>(`
`692`	`692`	`loc,`
`693`	`693`	`callee,`
`694`	`694`	`arguments: args`
`695`		`- } as any`
	`695`	`+ } as InferCodegenNodeType<T>`
`696`	`696`	`}`
`697`	`697`
`698`	`698`	`export function createFunctionExpression(`