vipshop#448 code review update

kfchu · kfchu · commit 7716705fe31c · 2018-07-27T11:43:08.000+08:00
diff --git a/saturn-console-api/src/main/java/com/vip/saturn/job/console/service/impl/SystemConfigServiceImpl.java b/saturn-console-api/src/main/java/com/vip/saturn/job/console/service/impl/SystemConfigServiceImpl.java
@@ -202,11 +202,13 @@ public Integer createConfig(SystemConfig systemConfig) throws SaturnJobConsoleEx
 		List<SystemConfig> systemConfigs = systemConfig4SqlService.selectByProperty(systemConfig.getProperty());
 
 		boolean found = false;
-		for (int i = 0; i < systemConfigs.size(); i++) {
-			SystemConfig config = systemConfigs.get(i);
-			if (StringUtils.equals(config.getProperty(), systemConfig.getProperty())) {
-				found = true;
-				break;
+		if (systemConfigs != null) {
+			for (int i = 0; i < systemConfigs.size(); i++) {
+				SystemConfig config = systemConfigs.get(i);
+				if (StringUtils.equals(config.getProperty(), systemConfig.getProperty())) {
+					found = true;
+					break;
+				}
 			}
 		}
 
@@ -226,7 +228,7 @@ public Integer updateConfig(SystemConfig systemConfig) throws SaturnJobConsoleEx
 		properties.add(systemConfig.getProperty());
 		List<SystemConfig> systemConfigs = systemConfig4SqlService.selectByPropertiesAndLastly(properties);
 
-		if (systemConfigs.size() == 0) {
+		if (systemConfigs == null || systemConfigs.isEmpty()) {
 			throw new SaturnJobConsoleException(
 					String.format("systemConfig %s not existed, update fail", systemConfig.getProperty()));
 		}
