modification in system-setproperty-hardcoded-secret-java

Sakshis · Sakshis · commit 249bbc70e798 · 2024-12-19T10:27:35.000Z
diff --git a/rules/java/security/system-setproperty-hardcoded-secret-java.yml b/rules/java/security/system-setproperty-hardcoded-secret-java.yml
@@ -21,20 +21,31 @@ utils:
     inside:
       stopBy: end
       kind: argument_list
+      has:
+        kind: string_literal
+        any:
+          - has:
+              kind: string_fragment
+              regex: "^javax.net.ssl.keyStorePassword$"
+          - has:
+              kind: string_fragment
+              regex: "^javax.net.ssl.trustStorePassword$"
       inside:
         stopBy: end
         kind: method_invocation
         all:
           - has:
               stopBy: end
+              field: object
               kind: identifier
+              regex: "^System$"
           - has:
               stopBy: end
+              field: name
               kind: identifier
               regex: "^setProperty$"
         inside:
           kind: expression_statement
 rule:
   any:
     - matches: match_string_literal
-
diff --git a/tests/__snapshots__/system-setproperty-hardcoded-secret-java-snapshot.yml b/tests/__snapshots__/system-setproperty-hardcoded-secret-java-snapshot.yml
@@ -23,6 +23,14 @@ snapshots:
       style: secondary
       start: 0
       end: 64
+    - source: javax.net.ssl.keyStorePassword
+      style: secondary
+      start: 20
+      end: 50
+    - source: '"javax.net.ssl.keyStorePassword"'
+      style: secondary
+      start: 19
+      end: 51
     - source: ("javax.net.ssl.keyStorePassword", "password")
       style: secondary
       start: 18
@@ -50,6 +58,14 @@ snapshots:
       style: secondary
       start: 0
       end: 66
+    - source: javax.net.ssl.trustStorePassword
+      style: secondary
+      start: 20
+      end: 52
+    - source: '"javax.net.ssl.trustStorePassword"'
+      style: secondary
+      start: 19
+      end: 53
     - source: ("javax.net.ssl.trustStorePassword", "password")
       style: secondary
       start: 18
