Update YAML rule for $APP.UseDeveloperExceptionPage and snapshot file

ESS-ENN · web-flow · commit cc2e5aa18326 · 2025-03-27T11:48:12.000+02:00
diff --git a/rules/csharp/security/stacktrace-disclosure-csharp.yml b/rules/csharp/security/stacktrace-disclosure-csharp.yml
@@ -14,32 +14,40 @@ note: >-
 ast-grep-essentials: true
 
 utils:
-  $APP.UseDeveloperExceptionPage(...):
+  kind_invocation_expression:
     kind: invocation_expression
-    pattern: $APP.UseDeveloperExceptionPage($$$)
     all:
-      - not:
-          inside:
-            stopBy: end
-            any:
-              - kind: postfix_unary_expression
-              - kind: member_access_expression
-                inside:
-                  kind: invocation_expression
-      - not:
-          inside:
-            stopBy: neighbor
-            kind: block
-            follows:
-              stopBy: end
-              any:
-                - kind: invocation_expression
-                  pattern: $ENV.IsDevelopment()
-                - kind: parenthesized_expression
-                  has:
-                    kind: invocation_expression
-                    pattern: $ENV.IsDevelopment()
-              inside:
-                kind: if_statement
+      - has:
+          nthChild: 1
+          kind: member_access_expression
+          pattern: $ENV.IsDevelopment
+      - has:
+          nthChild: 2
+          kind: argument_list
+
+  $APP.UseDeveloperExceptionPage(...):
+    kind: expression_statement
+    pattern: $APP.UseDeveloperExceptionPage($$$);
+    not:
+      inside:
+        stopBy: end
+        kind: if_statement
+        has:
+          nthChild: 1
+          any:
+            - matches: kind_invocation_expression
+            - kind: parenthesized_expression
+              has:
+                matches: kind_invocation_expression
 rule:
+  kind: expression_statement
   matches: $APP.UseDeveloperExceptionPage(...)
+  all:
+    - not:
+        has:
+          stopBy: end
+          kind: ERROR
+    - not:
+        inside:
+          stopBy: end
+          kind: ERROR
diff --git a/tests/__snapshots__/stacktrace-disclosure-csharp-snapshot.yml b/tests/__snapshots__/stacktrace-disclosure-csharp-snapshot.yml
@@ -2,41 +2,41 @@ id: stacktrace-disclosure-csharp
 snapshots:
   ? "if (!env.IsDevelopment())  \n    {\n        app.UseDeveloperExceptionPage();  \n    }\n"
   : labels:
-    - source: app.UseDeveloperExceptionPage()
+    - source: app.UseDeveloperExceptionPage();
       style: primary
       start: 42
-      end: 73
+      end: 74
   ? "if (DateTime.Now.DayOfWeek == DayOfWeek.Monday) \n    {\n        app.UseDeveloperExceptionPage(); \n    }\n"
   : labels:
-    - source: app.UseDeveloperExceptionPage()
+    - source: app.UseDeveloperExceptionPage();
       style: primary
       start: 63
-      end: 94
+      end: 95
   ? "if (DateTime.Now.DayOfWeek == DayOfWeek.Monday)  \n    {\n        app.UseDeveloperExceptionPage();\n    }\n"
   : labels:
-    - source: app.UseDeveloperExceptionPage()
+    - source: app.UseDeveloperExceptionPage();
       style: primary
       start: 64
-      end: 95
+      end: 96
   ? "if (env.IsProduction())  \n    {\n        app.UseDeveloperExceptionPage(); \n    }\n"
   : labels:
-    - source: app.UseDeveloperExceptionPage()
+    - source: app.UseDeveloperExceptionPage();
       style: primary
       start: 40
-      end: 71
+      end: 72
   ? "if (environment == \"dev\")  \n    {\n        app.UseDeveloperExceptionPage();  \n    }\n"
   : labels:
-    - source: app.UseDeveloperExceptionPage()
+    - source: app.UseDeveloperExceptionPage();
       style: primary
       start: 42
-      end: 73
+      end: 74
   ? |
     public void Configure(IApplicationBuilder app, IWebHostEnvironment env)
     {
     app.UseDeveloperExceptionPage();
     }
   : labels:
-    - source: app.UseDeveloperExceptionPage()
+    - source: app.UseDeveloperExceptionPage();
       style: primary
       start: 74
-      end: 105
+      end: 106
