Fixed christianalfoni#298: RangeError: Maximum call stack size exceeded with custom validator

Semigradsky · Semigradsky · commit d6950885a132 · 2016-07-05T11:36:06.000+03:00
diff --git a/src/utils.js b/src/utils.js
@@ -32,6 +32,8 @@ module.exports = {
       return false;
     } else if (Array.isArray(a)) {
       return !this.arraysDiffer(a, b);
+    } else if (typeof a === 'function') {
+      return a.toString() === b.toString();
     } else if (typeof a === 'object' && a !== null && b !== null) {
       return !this.objectsDiffer(a, b);
     }
diff --git a/tests/Utils-spec.js b/tests/Utils-spec.js
@@ -25,6 +25,10 @@ export default {
     test.equal(utils.isSame(objA, objH), false);
     test.equal(utils.isSame(objG, objA), false);
 
+    test.equal(utils.isSame(() => {}, () => {}), true);
+    test.equal(utils.isSame(objA, () => {}), false);
+    test.equal(utils.isSame(() => {}, objA), false);
+
     test.done();
 
   }

Original file line number	Diff line number	Diff line change
`@@ -32,6 +32,8 @@ module.exports = {`
`32`	`32`	`return false;`
`33`	`33`	`} else if (Array.isArray(a)) {`
`34`	`34`	`return !this.arraysDiffer(a, b);`
	`35`	`+ } else if (typeof a === 'function') {`
	`36`	`+ return a.toString() === b.toString();`
`35`	`37`	`} else if (typeof a === 'object' && a !== null && b !== null) {`
`36`	`38`	`return !this.objectsDiffer(a, b);`
`37`	`39`	`}`
Original file line number	Diff line number	Diff line change
`@@ -25,6 +25,10 @@ export default {`
`25`	`25`	`test.equal(utils.isSame(objA, objH), false);`
`26`	`26`	`test.equal(utils.isSame(objG, objA), false);`
`27`	`27`
	`28`	`+ test.equal(utils.isSame(() => {}, () => {}), true);`
	`29`	`+ test.equal(utils.isSame(objA, () => {}), false);`
	`30`	`+ test.equal(utils.isSame(() => {}, objA), false);`
	`31`	`+`
`28`	`32`	`test.done();`
`29`	`33`
`30`	`34`	`}`