bpo-40645: Fix reference leak in the _hashopenssl extension (pythonGH-26072)

encukou · web-flow · commit 3611db53f5b8 · 2021-05-12T09:04:34.000-07:00
The `PyModule_AddObjectRef` function doesn't steal a reference, so an extra `Py_DECREF` is needed.

Automerge-Triggered-By: GH:tiran
diff --git a/Modules/_hashopenssl.c b/Modules/_hashopenssl.c
@@ -2109,6 +2109,7 @@ hashlib_init_constructors(PyObject *module)
     if (PyModule_AddObjectRef(module, "_constructors", proxy) < 0) {
         return -1;
     }
+    Py_DECREF(proxy);
     return 0;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -2109,6 +2109,7 @@ hashlib_init_constructors(PyObject *module)`
`2109`	`2109`	`if (PyModule_AddObjectRef(module, "_constructors", proxy) < 0) {`
`2110`	`2110`	`return -1;`
`2111`	`2111`	`}`
	`2112`	`+ Py_DECREF(proxy);`
`2112`	`2113`	`return 0;`
`2113`	`2114`	`}`
`2114`	`2115`