Fix schema generation with custom page_size pagination param (encode#4567)

st4lk · tomchristie · commit 2519ce9128e4 · 2016-10-12T16:09:45.000+01:00
diff --git a/rest_framework/pagination.py b/rest_framework/pagination.py
@@ -290,9 +290,9 @@ def get_schema_fields(self, view):
             coreapi.Field(name=self.page_query_param, required=False, location='query')
         ]
         if self.page_size_query_param is not None:
-            fields.append([
+            fields.append(
                 coreapi.Field(name=self.page_size_query_param, required=False, location='query')
-            ])
+            )
         return fields
 
 
diff --git a/tests/test_schemas.py b/tests/test_schemas.py
@@ -20,6 +20,7 @@ def is_authenticated(self):
 
 class ExamplePagination(pagination.PageNumberPagination):
     page_size = 100
+    page_size_query_param = 'page_size'
 
 
 class EmptySerializer(serializers.Serializer):
@@ -64,7 +65,6 @@ def get_serializer(self, *args, **kwargs):
         assert self.action
         return super(ExampleViewSet, self).get_serializer(*args, **kwargs)
 
-
 if coreapi:
     schema_view = get_schema_view(title='Example API')
 else:
@@ -96,6 +96,7 @@ def test_anonymous_request(self):
                         action='get',
                         fields=[
                             coreapi.Field('page', required=False, location='query'),
+                            coreapi.Field('page_size', required=False, location='query'),
                             coreapi.Field('ordering', required=False, location='query')
                         ]
                     ),
@@ -136,6 +137,7 @@ def test_authenticated_request(self):
                         action='get',
                         fields=[
                             coreapi.Field('page', required=False, location='query'),
+                            coreapi.Field('page_size', required=False, location='query'),
                             coreapi.Field('ordering', required=False, location='query')
                         ]
                     ),
