Reject PrimaryKeyRelatedField bool lookup values (encode#7597)

amikrop · web-flow · commit 67ebdd32cdab · 2021-03-17T13:28:38.000Z
* Reject PrimaryKeyRelatedField bool lookup values

* Test PrimaryKeyRelatedField bool lookup rejection

* Fix indentation in test
diff --git a/rest_framework/relations.py b/rest_framework/relations.py
@@ -259,6 +259,8 @@ def to_internal_value(self, data):
             data = self.pk_field.to_internal_value(data)
         queryset = self.get_queryset()
         try:
+            if isinstance(data, bool):
+                raise TypeError
             return queryset.get(pk=data)
         except ObjectDoesNotExist:
             self.fail('does_not_exist', pk_value=data)
diff --git a/tests/test_relations.py b/tests/test_relations.py
@@ -107,6 +107,12 @@ def test_pk_related_lookup_invalid_type(self):
         msg = excinfo.value.detail[0]
         assert msg == 'Incorrect type. Expected pk value, received BadType.'
 
+    def test_pk_related_lookup_bool(self):
+        with pytest.raises(serializers.ValidationError) as excinfo:
+            self.field.to_internal_value(True)
+        msg = excinfo.value.detail[0]
+        assert msg == 'Incorrect type. Expected pk value, received bool.'
+
     def test_pk_representation(self):
         representation = self.field.to_representation(self.instance)
         assert representation == self.instance.pk
