Merge pull request apache#15379: Informative error for BigDecimal conversion in JdbcIO.

chamikaramj · web-flow · commit 9375df75a827 · 2021-08-25T11:25:35.000-07:00
diff --git a/sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/LogicalTypes.java b/sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/LogicalTypes.java
@@ -265,7 +265,13 @@ private FixedPrecisionNumeric(
 
     @Override
     public BigDecimal toInputType(BigDecimal base) {
-      checkArgument(base == null || (base.precision() == precision && base.scale() == scale));
+      checkArgument(
+          base == null || (base.precision() == precision && base.scale() == scale),
+          "Expected BigDecimal base to be null or have precision = %s (was %s), scale = %s (was %s)",
+          precision,
+          base.precision(),
+          scale,
+          base.scale());
       return base;
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -265,7 +265,13 @@ private FixedPrecisionNumeric(`
`265`	`265`
`266`	`266`	`@Override`
`267`	`267`	`public BigDecimal toInputType(BigDecimal base) {`
`268`		`- checkArgument(base == null \|\| (base.precision() == precision && base.scale() == scale));`
	`268`	`+ checkArgument(`
	`269`	`+ base == null \|\| (base.precision() == precision && base.scale() == scale),`
	`270`	`+ "Expected BigDecimal base to be null or have precision = %s (was %s), scale = %s (was %s)",`
	`271`	`+ precision,`
	`272`	`+ base.precision(),`
	`273`	`+ scale,`
	`274`	`+ base.scale());`
`269`	`275`	`return base;`
`270`	`276`	`}`
`271`	`277`	`}`