SupressWarnings correctly (GoogleCloudPlatform#824)

lesv · web-flow · commit e6d84cd89bf6 · 2017-08-22T18:31:26.000-07:00
diff --git a/appengine-java8/datastore/src/test/java/com/example/appengine/EntitiesTest.java b/appengine-java8/datastore/src/test/java/com/example/appengine/EntitiesTest.java
@@ -218,7 +218,7 @@ public void repeatedProperties_storesList() throws Exception {
     assertThat(retrievedFruits).containsExactlyElementsIn(favoriteFruit).inOrder();
   }
 
-  @SuppressWarnings(VariableDeclarationUsageDistance)
+  @SuppressWarnings("VariableDeclarationUsageDistance")
   @Test
   public void embeddedEntity_fromEmbedded_embedsProperties() throws Exception {
     Entity employee = new Entity("Employee");
diff --git a/appengine-java8/datastore/src/test/java/com/example/appengine/TransactionsTest.java b/appengine-java8/datastore/src/test/java/com/example/appengine/TransactionsTest.java
@@ -140,7 +140,6 @@ public void entityGroups() throws Exception {
     }
   }
 
-  @SuppressWarnings(VariableDeclarationUsageDistance)
   @Test
   public void creatingAnEntityInASpecificEntityGroup() throws Exception {
     String boardName = "my-message-board";
@@ -152,14 +151,14 @@ public void creatingAnEntityInASpecificEntityGroup() throws Exception {
     String messageText = "Some message.";
     Date postDate = new Date();
 
-    Transaction txn = datastore.beginTransaction();
-
     Key messageBoardKey = KeyFactory.createKey("MessageBoard", boardName);
 
     Entity message = new Entity("Message", messageBoardKey);
     message.setProperty("message_title", messageTitle);
     message.setProperty("message_text", messageText);
     message.setProperty("post_date", postDate);
+
+    Transaction txn = datastore.beginTransaction();
     datastore.put(txn, message);
 
     txn.commit();

Original file line number	Diff line number	Diff line change
`@@ -218,7 +218,7 @@ public void repeatedProperties_storesList() throws Exception {`
`218`	`218`	`assertThat(retrievedFruits).containsExactlyElementsIn(favoriteFruit).inOrder();`
`219`	`219`	`}`
`220`	`220`
`221`		`- @SuppressWarnings(VariableDeclarationUsageDistance)`
	`221`	`+ @SuppressWarnings("VariableDeclarationUsageDistance")`
`222`	`222`	`@Test`
`223`	`223`	`public void embeddedEntity_fromEmbedded_embedsProperties() throws Exception {`
`224`	`224`	`Entity employee = new Entity("Employee");`