Rename sandbox to Untitled

Ives van Hoorne · Ives van Hoorne · commit 2c99a7cf76cb · 2017-04-01T16:55:56.000+02:00
diff --git a/src/app/pages/Sandbox/Editor/Content/subviews/CodeEditor/index.js b/src/app/pages/Sandbox/Editor/Content/subviews/CodeEditor/index.js
@@ -253,7 +253,6 @@ export default class CodeEditor extends React.PureComponent {
   };
 
   handleSaveCode = async () => {
-    console.log('nog een keer');
     const { saveCode, preferences } = this.props;
     if (preferences.prettifyOnSaveEnabled) {
       await this.prettify();
diff --git a/src/app/pages/Sandbox/Editor/Workspace/SandboxDetails/SandboxTitle.js b/src/app/pages/Sandbox/Editor/Workspace/SandboxDetails/SandboxTitle.js
@@ -83,9 +83,11 @@ export default class SandboxTitle extends React.PureComponent {
   };
 
   handleRename = () => {
+    const { title } = this.props;
     const { newTitle } = this.state;
-
-    this.props.renameSandbox(newTitle);
+    if (newTitle !== title) {
+      this.props.renameSandbox(newTitle);
+    }
 
     this.setState({
       editing: false,
diff --git a/src/app/pages/Sandbox/Editor/Workspace/SandboxDetails/index.js b/src/app/pages/Sandbox/Editor/Workspace/SandboxDetails/index.js
@@ -53,7 +53,7 @@ export default class SandboxDetails extends React.PureComponent {
         <div>
           <SandboxTitle
             renameSandbox={this.renameSandbox}
-            title={sandbox.title || sandbox.id}
+            title={sandbox.title || 'Untitled'}
           />
           {sandbox.forkedFromSandbox &&
             <ForkText>
diff --git a/src/app/pages/Sandbox/index.js b/src/app/pages/Sandbox/index.js
@@ -2,7 +2,6 @@
 import React from 'react';
 import { bindActionCreators } from 'redux';
 import { connect } from 'react-redux';
-import { Route, Switch } from 'react-router-dom';
 import { createSelector } from 'reselect';
 import { denormalize } from 'normalizr';
 import sandboxEntity from 'app/store/entities/sandboxes/entity';
@@ -93,13 +92,7 @@ class SandboxPage extends React.PureComponent {
 
     return (
       <Centered horizontal vertical>
-        <Switch>
-          <Route
-            render={matchParams => (
-              <Editor sandbox={sandbox} {...matchParams} />
-            )}
-          />
-        </Switch>
+        <Editor sandbox={sandbox} />
       </Centered>
     );
   }
diff --git a/src/app/store/entities/sandboxes/actions.js b/src/app/store/entities/sandboxes/actions.js
@@ -112,7 +112,6 @@ const forkSandbox = (id: string) => async (
   dispatch: Function,
   getState: Function
 ) => {
-  console.log('asking for a friend');
   const { data } = await dispatch(
     doRequest(FORK_SANDBOX_API_ACTIONS, `sandboxes/${id}/fork`, {
       method: 'POST',
@@ -266,7 +265,6 @@ export default {
     dispatch: Function,
     getState: Function
   ) => {
-    console.log('Called');
     const module = modulesSelector(getState())[moduleId];
     const sandboxId = await dispatch(maybeForkSandbox(id));
 
