Skip to content

Commit 5be8ebb

Browse files
authored
Stop using sharp for images (codesandbox#393)
* Stop using sharp * Use React 16 * Include map and set
1 parent ed0ed8c commit 5be8ebb

File tree

9 files changed

+13
-51
lines changed

9 files changed

+13
-51
lines changed

packages/homepage/gatsby-browser.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
import 'core-js/es6/map';
2+
import 'core-js/es6/set';

packages/homepage/gatsby-config.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,6 @@ module.exports = {
6060
],
6161
},
6262
},
63-
`gatsby-transformer-sharp`,
6463
`gatsby-plugin-styled-components`,
6564
`gatsby-plugin-react-helmet`,
6665
{

packages/homepage/gatsby-node.js

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
const { createFilePath } = require('gatsby-source-filesystem');
2-
const { resolve } = require('path');
2+
const { resolve, dirname } = require('path');
33

44
// Parse date information out of post filename.
55
const BLOG_POST_FILENAME_REGEX = /([0-9]+)\-([0-9]+)\-([0-9]+)\-(.+)\.md$/;
@@ -138,5 +138,11 @@ exports.modifyWebpackConfig = ({ config }) => {
138138
extensions: ['', '.js', '.jsx', '.json'],
139139
},
140140
});
141+
142+
config._config.resolve.alias = {
143+
react: dirname(require.resolve('react')),
144+
'react-dom': dirname(require.resolve('react-dom')),
145+
};
146+
141147
return config;
142148
};

packages/homepage/package.json

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
"dependencies": {
77
"algoliasearch": "^3.24.5",
88
"gatsby": "^1.9.73",
9-
"gatsby-image": "^1.0.24",
109
"gatsby-link": "^1.6.22",
1110
"gatsby-plugin-google-fonts": "^0.0.3",
1211
"gatsby-plugin-google-tagmanager": "^1.0.8",
@@ -20,7 +19,6 @@
2019
"gatsby-remark-prismjs": "^1.2.11",
2120
"gatsby-source-filesystem": "^1.5.8",
2221
"gatsby-transformer-remark": "^1.7.24",
23-
"gatsby-transformer-sharp": "^1.6.16",
2422
"gsap": "^1.20.3",
2523
"react-media": "^1.6.1",
2624
"react-transition-group": "^2.2.1",

packages/homepage/src/pages/index.js

Lines changed: 1 addition & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -39,26 +39,9 @@ export default class HomePage extends React.Component {
3939
<NPMFeature />
4040
<CycleFeature />
4141
<ExtraFeatures />
42-
<RecentPublications sizes={this.props.data.publicationImages.edges} />
42+
<RecentPublications />
4343
<Patron />
4444
</div>
4545
);
4646
}
4747
}
48-
49-
export const pageQuery = graphql`
50-
query ImageSizesQuery {
51-
publicationImages: allImageSharp(
52-
filter: { id: { regex: "/RecentPublications/" } }
53-
) {
54-
edges {
55-
node {
56-
id
57-
sizes(maxWidth: 400) {
58-
...GatsbyImageSharpSizes
59-
}
60-
}
61-
}
62-
}
63-
}
64-
`;

packages/homepage/src/screens/home/RecentPublications/index.js

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
import React from 'react';
22
import styled from 'styled-components';
33

4-
import Img from 'gatsby-image';
5-
64
import MaxWidth from 'common/components/flex/MaxWidth';
75

86
import codesandbox2Image from './1-codesandbox2.png';
@@ -65,10 +63,9 @@ const PublicationDescription = styled.p`
6563
text-shadow: 0 1px 3px rgba(0, 0, 0, 0.3);
6664
`;
6765

68-
const PublicationItem = ({ title, image, url, description, sizes }) => (
66+
const PublicationItem = ({ title, image, url, description }) => (
6967
<Item href={url} target="_blank" rel="noopener noreferrer">
70-
<Img
71-
sizes={sizes}
68+
<img
7269
style={{ boxShadow: '0 4px 8px rgba(0, 0, 0, 0.3)' }}
7370
src={image}
7471
alt={title}
@@ -78,7 +75,7 @@ const PublicationItem = ({ title, image, url, description, sizes }) => (
7875
</Item>
7976
);
8077

81-
export default ({ sizes }) => (
78+
export default () => (
8279
<Container>
8380
<MaxWidth width={1280}>
8481
<Title>Recent Publications</Title>
@@ -89,21 +86,18 @@ export default ({ sizes }) => (
8986
description="Announcing CodeSandbox 2.0. With GitHub commiting, a new homepage and support for static files."
9087
url="https://medium.com/@compuives/announcing-codesandbox-2-0-938cff3a0fcb"
9188
image={codesandbox2Image}
92-
sizes={sizes[2].node.sizes}
9389
/>
9490
<PublicationItem
9591
title="The Journey of CodeSandbox"
9692
description="Ives explains how CodeSandbox came to be, how it works and what the future holds."
9793
url="https://www.youtube.com/watch?v=5lR29NsJKW8"
9894
image={zeitTalkImage}
99-
sizes={sizes[0].node.sizes}
10095
/>
10196
<PublicationItem
10297
title="NPM in the browser"
10398
description="What we have done to make npm work in the browser, and what we will do in the future."
10499
url="https://hackernoon.com/how-we-make-npm-packages-work-in-the-browser-announcing-the-new-packager-6ce16aa4cee6"
105100
image={npmArticleImage}
106-
sizes={sizes[1].node.sizes}
107101
/>
108102
</Items>
109103
</MaxWidth>

yarn.lock

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -5679,13 +5679,6 @@ gatsby-cli@^1.1.20, gatsby-cli@^1.1.22:
56795679
yargs "^8.0.2"
56805680
yurnalist "^0.2.1"
56815681

5682-
gatsby-image@^1.0.24:
5683-
version "1.0.24"
5684-
resolved "https://registry.yarnpkg.com/gatsby-image/-/gatsby-image-1.0.24.tgz#f6c8bb7caa0cc9061636a246e588ec463570c7c4"
5685-
dependencies:
5686-
babel-runtime "^6.26.0"
5687-
prop-types "^15.6.0"
5688-
56895682
gatsby-link@^1.6.22:
56905683
version "1.6.28"
56915684
resolved "https://registry.yarnpkg.com/gatsby-link/-/gatsby-link-1.6.28.tgz#12b799aa12663ae22f626195ab258e0ee5dddc9c"
@@ -5825,15 +5818,6 @@ gatsby-transformer-remark@^1.7.24:
58255818
unist-util-select "^1.5.0"
58265819
unist-util-visit "^1.1.1"
58275820

5828-
gatsby-transformer-sharp@^1.6.16:
5829-
version "1.6.16"
5830-
resolved "https://registry.yarnpkg.com/gatsby-transformer-sharp/-/gatsby-transformer-sharp-1.6.16.tgz#16464dcfbb2099f49805b2e244da0b3fea63b88e"
5831-
dependencies:
5832-
babel-runtime "^6.26.0"
5833-
bluebird "^3.5.0"
5834-
fs-extra "^4.0.2"
5835-
image-size "^0.6.0"
5836-
58375821
gatsby@^1.9.73:
58385822
version "1.9.118"
58395823
resolved "https://registry.yarnpkg.com/gatsby/-/gatsby-1.9.118.tgz#76d94faaa91f0ebe39fd2346f91a26146bff4009"
@@ -7021,10 +7005,6 @@ image-size@^0.5.1:
70217005
version "0.5.5"
70227006
resolved "https://registry.yarnpkg.com/image-size/-/image-size-0.5.5.tgz#09dfd4ab9d20e29eb1c3e80b8990378df9e3cb9c"
70237007

7024-
image-size@^0.6.0:
7025-
version "0.6.1"
7026-
resolved "https://registry.yarnpkg.com/image-size/-/image-size-0.6.1.tgz#98122a562d59dcc097ef1b2c8191866eb8f5d663"
7027-
70287008
imagemin-pngquant@^5.0.0:
70297009
version "5.0.1"
70307010
resolved "https://registry.yarnpkg.com/imagemin-pngquant/-/imagemin-pngquant-5.0.1.tgz#d8a329da553afa226b11ce62debe0b7e37b439e6"

0 commit comments

Comments
 (0)