Skip to content

Commit 6d2973b

Browse files
author
Ives van Hoorne
committed
Fix embed codemirror loading
1 parent 0b6ba35 commit 6d2973b

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

packages/app/src/app/components/sandbox/CodeEditor/index.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,8 @@ type Props = {
2222
};
2323

2424
const CodeMirror = Loadable({
25-
loader: () => import(/* webpackChunkName: 'codemirror' */ './CodeMirror'),
25+
loader: () =>
26+
import(/* webpackChunkName: 'codemirror-editor' */ './CodeMirror'),
2627
LoadingComponent: Loading,
2728
});
2829

packages/app/src/embed/App.js

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,13 @@ import Header from './components/Header';
1919
import Content from './components/Content';
2020
import Sidebar from './components/Sidebar';
2121

22+
// Okay, this looks veeeery strange, we need this because Webpack has a bug currently
23+
// that makes it think we have core-js/es6/map available in embed, but we don't.
24+
// So we explicitly make sure that we have `core-js/es6/map` available by declaring
25+
// new Map.
26+
// eslint-disable-next-line
27+
new Map();
28+
2229
const Container = styled.div`
2330
display: flex;
2431
flex-direction: column;

0 commit comments

Comments
 (0)