Fix const errors being hidden by bug in const_missing (ruby-grape#1876)

dandehavilland · dblock · commit 6aa32824be74 · 2019-04-16T08:21:46.000-04:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -9,6 +9,7 @@
 #### Fixes
 
 * [#1868](https://github.com/ruby-grape/grape/pull/1868): Fix NoMethodError with none hash params - [@ksss](https://github.com/ksss).
+* [#1876](https://github.com/ruby-grape/grape/pull/1876): Fix const errors being hidden by bug in `const_missing` - [@dandehavilland](https://github.com/dandehavilland).
 
 ### 1.2.3 (2019/01/16)
 
diff --git a/lib/grape/api.rb b/lib/grape/api.rb
@@ -64,8 +64,6 @@ def api.inherited(child_api)
       def const_missing(*args)
         if base_instance.const_defined?(*args)
           base_instance.const_get(*args)
-        elsif parent && parent.const_defined?(*args)
-          parent.const_get(*args)
         else
           super
         end
diff --git a/spec/grape/api_spec.rb b/spec/grape/api_spec.rb
@@ -3869,4 +3869,21 @@ def before
       expect(grape_api.eql?(MyAPI))
     end
   end
+
+  describe 'const_missing' do
+    subject(:grape_api) { Class.new(Grape::API) }
+    let(:mounted) do
+      Class.new(Grape::API) do
+        get '/missing' do
+          SomeRandomConstant
+        end
+      end
+    end
+
+    before { subject.mount mounted => '/const' }
+
+    it 'raises an error' do
+      expect { get '/const/missing' }.to raise_error(NameError).with_message(/SomeRandomConstant/)
+    end
+  end
 end
