throw error for 1.0

Ubuntu · Ubuntu · commit 5bd1eb8a0795 · 2015-12-19T16:09:07.000Z
diff --git a/index.js b/index.js
@@ -19,32 +19,41 @@ var stripHtml = function(str) {
   return str.replace(/<(?:.|\n)*?>/gm, '');
 }
 
+var parseRSS1 = function(xmlObj, callback) {
+  callback("RSS 1.0 parsing not yet implemented.")
+}
+
+var parseRSS2 = function(xmlObj, callback) {
+  var json = {feed: {entries: []}};
+  var channel = xmlObj.rss.channel[0];
+  if (channel['atom:link']) json.feed.feedUrl = channel['atom:link'][0].href;
+  TOP_FIELDS.forEach(function(f) {
+    if (channel[f]) json.feed[f] = channel[f][0];
+  })
+  var items = channel.item;
+  (items || []).forEach(function(item) {
+    var entry = {};
+    ITEM_FIELDS.forEach(function(f) {
+      if (item[f]) entry[f] = item[f][0];
+    })
+    if (item.description) {
+      entry.content = item.description[0];
+      entry.contentSnippet = Entities.decode(stripHtml(entry.content));
+    }
+    if (item.guid) {
+      entry.guid = item.guid[0]._;
+    }
+    if (item.category) entry.categories = item.category;
+    json.feed.entries.push(entry);
+  })
+  callback(null, json);
+}
+
 Parser.parseString = function(xml, callback) {
   XML2JS.parseString(xml, function(err, result) {
     if (err) throw err;
-    var json = {feed: {entries: []}};
-    var channel = result.rss.channel[0];
-    if (channel['atom:link']) json.feed.feedUrl = channel['atom:link'][0].href;
-    TOP_FIELDS.forEach(function(f) {
-      if (channel[f]) json.feed[f] = channel[f][0];
-    })
-    var items = channel.item;
-    (items || []).forEach(function(item) {
-      var entry = {};
-      ITEM_FIELDS.forEach(function(f) {
-        if (item[f]) entry[f] = item[f][0];
-      })
-      if (item.description) {
-        entry.content = item.description[0];
-        entry.contentSnippet = Entities.decode(stripHtml(entry.content));
-      }
-      if (item.guid) {
-        entry.guid = item.guid[0]._;
-      }
-      if (item.category) entry.categories = item.category;
-      json.feed.entries.push(entry);
-    })
-    callback(null, json);
+    if (result.rss && result.rss.$.version && result.rss.$.version.indexOf('2') === 0) return parseRSS2(result, callback);
+    else return parseRSS1(result, callback);
   });
 }
 
diff --git a/test/parser.js b/test/parser.js
@@ -21,4 +21,11 @@ describe('Parser', function() {
       done();
     })
   })
+
+  it('should parse craigslist', function(done) {
+    Parser.parseURL('https://seattle.craigslist.org/search/act?format=rss', function(err, parsed) {
+      Expect(err).to.not.equal(null);
+      done();
+    })
+  })
 })
