Throw error on bad URL passed into parser

joshbeckman · joshbeckman · commit 73ba422d49d3 · 2015-11-29T15:58:24.000-06:00
diff --git a/dist/rss-parser.js b/dist/rss-parser.js
@@ -53,8 +53,7 @@ Parser.parseURL = function(url, callback) {
 
   try{ xhr = new XMLHttpRequest(); }catch(e){
     try{ xhr = new ActiveXObject('Msxml2.XMLHTTP'); }catch (error){
-      if (console) console.log('RSSParser: XMLHttpRequest not supported');
-      return null;
+      callback(new Error('RSSParser: XMLHttpRequest not supported'));
     }
   }
   requestTimeout = setTimeout(function() {
@@ -72,8 +71,12 @@ Parser.parseURL = function(url, callback) {
     }
   };
 
-  xhr.open('GET', url, true);
-  xhr.send();
+  try {
+    xhr.open('GET', url, true);
+    xhr.send();
+  } catch (err) {
+    callback(new Error(err));
+  }
 }
 
 Parser.parseFile = function(file, callback) {

Original file line number	Diff line number	Diff line change
`@@ -53,8 +53,7 @@ Parser.parseURL = function(url, callback) {`
`53`	`53`
`54`	`54`	`try{ xhr = new XMLHttpRequest(); }catch(e){`
`55`	`55`	`try{ xhr = new ActiveXObject('Msxml2.XMLHTTP'); }catch (error){`
`56`		`- if (console) console.log('RSSParser: XMLHttpRequest not supported');`
`57`		`- return null;`
	`56`	`+ callback(new Error('RSSParser: XMLHttpRequest not supported'));`
`58`	`57`	`}`
`59`	`58`	`}`
`60`	`59`	`requestTimeout = setTimeout(function() {`
`@@ -72,8 +71,12 @@ Parser.parseURL = function(url, callback) {`
`72`	`71`	`}`
`73`	`72`	`};`
`74`	`73`
`75`		`- xhr.open('GET', url, true);`
`76`		`- xhr.send();`
	`74`	`+ try {`
	`75`	`+ xhr.open('GET', url, true);`
	`76`	`+ xhr.send();`
	`77`	`+ } catch (err) {`
	`78`	`+ callback(new Error(err));`
	`79`	`+ }`
`77`	`80`	`}`
`78`	`81`
`79`	`82`	`Parser.parseFile = function(file, callback) {`