return error if feed doesn't look like rss 1 or 2

rbren · rbren · commit fa8b51d44df0 · 2017-07-06T14:30:39.000Z
diff --git a/index.js b/index.js
@@ -244,8 +244,10 @@ Parser.parseString = function(xml, options, callback) {
       return parseAtomFeed(result, options, callback)
     } else if (result.rss && result.rss.$.version && result.rss.$.version.indexOf('2') === 0) {
       return parseRSS2(result, options, callback);
-    } else {
+    } else if (result['rdf:RDF']) {
       return parseRSS1(result, options, callback);
+    } else {
+      return callback(new Error("Feed not recognized as RSS 1 or 2."))
     }
   });
 }
diff --git a/test/input/unrecognized.rss b/test/input/unrecognized.rss
@@ -0,0 +1,2 @@
+<head><title>Document Moved</title></head>
+<body><h1>Object Moved</h1>This document may be found <a HREF="http://fishhawk2.marketwatch.com/rss/pf/">here</a></body>
diff --git a/test/parser.js b/test/parser.js
@@ -70,6 +70,13 @@ describe('Parser', function() {
     testParseForFile('narro', 'rss', done);
   });
 
+  it('should throw error for unrecognized', function(done) {
+    Parser.parseFile(__dirname + '/input/unrecognized.rss', (err, parsed) => {
+      Expect(err.message).to.contain('Feed not recognized as RSS');
+      done();
+    })
+  })
+
   it('should parse custom fields', function(done) {
     var options = {
       customFields: {

Original file line number	Diff line number	Diff line change
`@@ -244,8 +244,10 @@ Parser.parseString = function(xml, options, callback) {`
`244`	`244`	`return parseAtomFeed(result, options, callback)`
`245`	`245`	`} else if (result.rss && result.rss.$.version && result.rss.$.version.indexOf('2') === 0) {`
`246`	`246`	`return parseRSS2(result, options, callback);`
`247`		`- } else {`
	`247`	`+ } else if (result['rdf:RDF']) {`
`248`	`248`	`return parseRSS1(result, options, callback);`
	`249`	`+ } else {`
	`250`	`+ return callback(new Error("Feed not recognized as RSS 1 or 2."))`
`249`	`251`	`}`
`250`	`252`	`});`
`251`	`253`	`}`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	`+<head><title>Document Moved</title></head>`
	`2`	`+<body><h1>Object Moved</h1>This document may be found <a HREF="http://fishhawk2.marketwatch.com/rss/pf/">here</a></body>`