Skip to content

Commit 2965bad

Browse files
committed
Merge pull request mozilla#1901 from brendandahl/ff16_sync
Sync up a few files with mozcentral. Address mozcentral review comments.
2 parents 9c012f8 + f16c6f1 commit 2965bad

File tree

3 files changed

+5
-9
lines changed

3 files changed

+5
-9
lines changed

extensions/firefox/components/PdfStreamConverter.js

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -132,16 +132,13 @@ ChromeActions.prototype = {
132132
var originalUrl = data.originalUrl;
133133
// The data may not be downloaded so we need just retry getting the pdf with
134134
// the original url.
135-
var blobUrl = data.blobUrl || originalUrl;
136-
var originalUri = NetUtil.newURI(originalUrl);
137-
var blobUri = NetUtil.newURI(blobUrl);
135+
var originalUri = NetUtil.newURI(data.originalUrl);
136+
var blobUri = data.blobUrl ? NetUtil.newURI(data.blobUrl) : originalUri;
138137
var extHelperAppSvc =
139138
Cc['@mozilla.org/uriloader/external-helper-app-service;1'].
140139
getService(Ci.nsIExternalHelperAppService);
141140
var frontWindow = Cc['@mozilla.org/embedcomp/window-watcher;1'].
142141
getService(Ci.nsIWindowWatcher).activeWindow;
143-
var ioService = Services.io;
144-
var channel = ioService.newChannel(originalUrl, null, null);
145142

146143
NetUtil.asyncFetch(blobUri, function(aInputStream, aResult) {
147144
if (!Components.isSuccessCode(aResult)) {

l10n/en-US/chrome.properties

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
11
# Chrome notification bar messages and buttons
22
unsupported_feature=This PDF document might not be displayed correctly.
33
open_with_different_viewer=Open With Different Viewer
4+
open_with_different_viewer.accessKey=o

test/mozcentral/Makefile.in

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,11 @@ VPATH = @srcdir@
99
relativesrcdir = browser/extensions/pdfjs/test
1010

1111
include $(DEPTH)/config/autoconf.mk
12-
include $(topsrcdir)/config/rules.mk
1312

14-
_BROWSER_TEST_FILES = \
13+
MOCHITEST_BROWSER_FILES = \
1514
browser_pdfjs_main.js \
1615
browser_pdfjs_savedialog.js \
1716
file_pdfjs_test.pdf \
1817
$(NULL)
1918

20-
libs:: $(_BROWSER_TEST_FILES)
21-
$(INSTALL) $(foreach f,$^,"$f") $(DEPTH)/_tests/testing/mochitest/browser/$(relativesrcdir)
19+
include $(topsrcdir)/config/rules.mk

0 commit comments

Comments
 (0)