Add new test group for "null and undefined"

Krinkle · Krinkle · commit b1f64d9ca2e9 · 2011-09-18T00:50:44.000Z
* move the two existing tests to there
* Also add a new test to the "Basic" group for a literal undefined (which should and we already do, return undefined for that, just adding here to make sure we keep watching this)
diff --git a/src/jquery.json.js b/src/jquery.json.js
@@ -112,7 +112,7 @@
 				} else if (type === 'string') {
 					name = $.quoteString(k);
 				} else {
-					//skip non-string or number keys
+					// Keys must be numerical or string. Skip others
 					continue;
 				}
 
diff --git a/test/jquery.json.test.js b/test/jquery.json.test.js
@@ -32,11 +32,6 @@ test( 'Basic toJSON usage', function(){
 		'{"apple":7,"pear":5}',
 		'Objects with multiple members should be separated by a comma'
 	);
-	equalJSON(
-		{ apple: undefined, pear: 5 },
-		'{"pear":5}',
-		'Objects with a member with value of type undefined should be removed'
-	);
 	equalJSON(
 		2.5,
 		'2.5',
@@ -77,11 +72,6 @@ test( 'Basic toJSON usage', function(){
 		'{"dDefault":"1.84467440737E+19"}',
 		'Object with lower case key and value that should not be touched'
 	);
-	equalJSON(
-		[undefined, undefined, 1, 2],
-		'[null,null,1,2]',
-		'Resolve undefined to null when encountered as object member values'
-	);
 	equalJSON(
 		[0, false, function() {}],
 		'[0,false,null]',
@@ -102,6 +92,11 @@ test( 'Basic toJSON usage', function(){
 		'null',
 		'null is null'
 	);
+	equalJSON(
+		undefined,
+		undefined,
+		'undefined is not valid and should not return a string "undefined" but literally undefined'
+	);
 
 });
 
@@ -160,4 +155,21 @@ test( 'Function arguments object', function(){
 
 	argTest( 'foo', 'bar', 'baz' );
 
-})
+});
+
+test( 'Undefined and null', function(){
+
+
+	equalJSON(
+		{ apple: undefined, pear: 5 },
+		'{"pear":5}',
+		'Objects with a member with value of type undefined should be removed'
+	);
+	equalJSON(
+		[undefined, undefined, 1, 2],
+		'[null,null,1,2]',
+		'Resolve undefined to null when encountered as object member values'
+	);
+
+
+});

Original file line number	Diff line number	Diff line change
`@@ -112,7 +112,7 @@`
`112`	`112`	`} else if (type === 'string') {`
`113`	`113`	`name = $.quoteString(k);`
`114`	`114`	`} else {`
`115`		`- //skip non-string or number keys`
	`115`	`+ // Keys must be numerical or string. Skip others`
`116`	`116`	`continue;`
`117`	`117`	`}`
`118`	`118`