send src logs to output channel

ShMcK · ShMcK · commit 4e1e1a562f57 · 2022-01-02T10:45:49.000-08:00
Signed-off-by: shmck &lt;shawn.j.mckay@gmail.com&gt;
diff --git a/src/actions/onOpenLogs.ts b/src/actions/onOpenLogs.ts
@@ -1,5 +1,5 @@
 import * as T from 'typings'
-import { showOutput } from '../services/testRunner/output'
+import { showOutput } from '../services/logger/output'
 
 export const onOpenLogs = async (action: T.Action): Promise<void> => {
   const channel = action.payload.channel
diff --git a/src/environment.ts b/src/environment.ts
@@ -10,9 +10,6 @@ export type Env = 'test' | 'local' | 'development' | 'production'
 // @ts-ignore
 export const NODE_ENV: Env = process.env.NODE_ENV || 'development'
 
-// toggle logging
-export const LOG = (process.env.CODEROAD_ENABLE_LOG || '').toLowerCase() === 'true'
-
 // error logging tool
 export const INSTRUMENTATION_KEY = '6ff37c76-72f3-48e3-a1b9-d5636f519b7b'
 
diff --git a/src/services/logger/index.ts b/src/services/logger/index.ts
@@ -1,18 +1,17 @@
-import { LOG } from '../../environment'
+import { getOutputChannel } from './output'
 
 export type Log = any
 
+const logChannel = getOutputChannel('CodeRoad (Logs)')
+
 const logger = (...messages: Log[]): void => {
-  if (!LOG) {
-    return
-  }
   // Inside vscode, you console.log does not allow more than 1 param
   // to get around it, we can log with multiple log statements
   for (const message of messages) {
     if (typeof message === 'object') {
-      console.log(JSON.stringify(message))
+      logChannel.appendLine(JSON.stringify(message))
     } else {
-      console.log(message)
+      logChannel.appendLine(message)
     }
   }
 }
diff --git a/src/services/logger/output.ts b/src/services/logger/output.ts
@@ -6,7 +6,7 @@ const channels:
       /* */
     } = {}
 
-const getOutputChannel = (name: string): vscode.OutputChannel => {
+export const getOutputChannel = (name: string): vscode.OutputChannel => {
   if (!channels[name]) {
     channels[name] = vscode.window.createOutputChannel(name)
   }
diff --git a/src/services/testRunner/index.ts b/src/services/testRunner/index.ts
@@ -6,7 +6,7 @@ import parser, { ParserOutput } from './parser'
 import parseSubtasks from './subtasks'
 import { debounce, throttle } from './throttle'
 import { onError } from '../telemetry'
-import { clearOutput, addOutput } from './output'
+import { clearOutput, addOutput } from '../logger/output'
 import { formatFailOutput } from './formatOutput'
 
 interface Callbacks {
@@ -18,7 +18,6 @@ interface Callbacks {
 }
 
 const failChannelName = 'CodeRoad (Tests)'
-const logChannelName = 'CodeRoad (Logs)'
 
 interface TestRunnerParams {
   position: T.Position
@@ -91,7 +90,7 @@ const createTestRunner = (data: TT.Tutorial, callbacks: Callbacks): ((params: an
 
     const tap: ParserOutput = parser(stdout || '')
 
-    addOutput({ channel: logChannelName, text: tap.logs.join('\n'), show: false })
+    logger(tap.logs.join('\n'))
 
     if (stderr) {
       if (!tap.failed.length) {

Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@ const channels:`
`6`	`6`	`/* */`
`7`	`7`	`} = {}`
`8`	`8`
`9`		`-const getOutputChannel = (name: string): vscode.OutputChannel => {`
	`9`	`+export const getOutputChannel = (name: string): vscode.OutputChannel => {`
`10`	`10`	`if (!channels[name]) {`
`11`	`11`	`channels[name] = vscode.window.createOutputChannel(name)`
`12`	`12`	`}`