clean up test fail logs

ShMcK · ShMcK · commit 8653dcae17f6 · 2022-01-02T11:32:49.000-08:00
Signed-off-by: shmck &lt;shawn.j.mckay@gmail.com&gt;
diff --git a/src/commands.ts b/src/commands.ts
@@ -21,15 +21,15 @@ interface CreateCommandProps {
 }
 
 let sendToClient = (action: T.Action): void => {
-  // function is replaced when webclient loads
+  // function is replaced when webview mounts
 }
 
 // This makes it easier to pass the send
 // function throughout the codebase
 export const send = (action: T.Action): void => {
-  logger(`EXT TO CLIENT: "${typeof action === 'string' ? action : action.type}"`)
-
-  if (action) sendToClient(action)
+  // log send of event to client
+  logger(`${typeof action === 'string' ? action : action.type}`)
+  sendToClient(action)
 }
 
 export const createCommands = (commandProps: CreateCommandProps): { [key: string]: any } => {
@@ -91,7 +91,7 @@ export const createCommands = (commandProps: CreateCommandProps): { [key: string
         },
         onRun: (position: T.Position) => {
           // send test run message back to client
-          send({ type: 'TEST_RUNNING', payload: { position } })
+          send({ type: 'START_TEST', payload: { position } })
         },
         onLoadSubtasks: ({ summary }) => {
           send({ type: 'LOAD_SUBTASK_RESULTS', payload: { summary } })
diff --git a/src/services/testRunner/index.ts b/src/services/testRunner/index.ts
@@ -72,7 +72,7 @@ const createTestRunner = (data: TT.Tutorial, callbacks: Callbacks): ((params: an
           command = [command, testRunnerFilterArg, testFilter].join(' ')
         }
       }
-      logger('COMMAND', command)
+      logger(`COMMAND: ${command}`)
       result = await exec({ command, dir: testRunnerConfig.directory })
     } catch (err: any) {
       result = { stdout: err.stdout, stderr: err.stack }
@@ -84,13 +84,15 @@ const createTestRunner = (data: TT.Tutorial, callbacks: Callbacks): ((params: an
       return
     }
 
-    logger('----------------- PROCESS TEST -----------------')
+    logger('---------------- TEST RESULTS -----------------')
 
     const { stdout, stderr } = result
 
     const tap: ParserOutput = parser(stdout || '')
 
-    logger(tap.logs.join('\n'))
+    if (tap.logs.length) {
+      logger(tap.logs.join('\n'))
+    }
 
     if (stderr) {
       if (!tap.failed.length) {
diff --git a/web-app/src/services/state/machine.ts b/web-app/src/services/state/machine.ts
@@ -157,7 +157,7 @@ export const createMachine = (options: any) => {
                     LOAD_SUBTASK_RESULTS: {
                       actions: ['testSubtasks'],
                     },
-                    TEST_RUNNING: 'TestRunning',
+                    START_TEST: 'TestRunning',
                     STEP_SOLUTION_LOAD: {
                       actions: ['editorLoadSolution'],
                     },
