clenaup error messages

ShMcK · ShMcK · commit efda471987b6 · 2022-01-02T15:37:40.000-08:00
Signed-off-by: shmck &lt;shawn.j.mckay@gmail.com&gt;
diff --git a/src/commands.ts b/src/commands.ts
@@ -75,7 +75,7 @@ export const createCommands = (commandProps: CreateCommandProps): { [key: string
       }
       testRunner = createTestRunner(data, {
         onSuccess: (position: T.Position) => {
-          logger('test pass position', position)
+          logger(`Test pass position: ${JSON.stringify(position)}`)
           // send test pass message back to client
           channel.context.position.set({ ...position, complete: true })
           send({ type: 'TEST_PASS', payload: { position: { ...position, complete: true } } })
diff --git a/src/services/git/index.ts b/src/services/git/index.ts
@@ -53,7 +53,7 @@ export async function saveCommit(message: string): Promise<never | void> {
     logger(`Error: ${stderr}`)
     throw new Error('Error saving progress to Git')
   }
-  logger(stdout)
+  logger(`Commit saved: ${stdout}`)
 }
 
 export async function clear(): Promise<Error | void> {
diff --git a/src/services/hooks/utils/runCommands.ts b/src/services/hooks/utils/runCommands.ts
@@ -15,7 +15,7 @@ const runCommands = async (commands: string[] = []): Promise<void> => {
     let result: { stdout: string; stderr: string }
     try {
       result = await exec({ command })
-      logger(result)
+      logger(`Command output: ${JSON.stringify(result)}`)
     } catch (error: any) {
       logger(`Command failed: ${error.message}`)
       send({ type: 'COMMAND_FAIL', payload: { process: { ...process, status: 'FAIL' } } })
diff --git a/src/services/telemetry/index.ts b/src/services/telemetry/index.ts
@@ -31,14 +31,12 @@ export const deactivate = (): void => {
 }
 
 export const onError = (error: Error, properties?: Properties, measurements?: Measurements): void => {
-  logger(error, properties, measurements)
   if (reporter) {
     reporter.sendTelemetryException(error, properties, measurements)
   }
 }
 
 export const onEvent = (eventName: string, properties?: Properties, measurements?: Measurements): void => {
-  logger(eventName, properties, measurements)
   if (reporter) {
     reporter.sendTelemetryEvent(eventName, properties, measurements)
   }
diff --git a/web-app/src/components/Markdown/index.tsx b/web-app/src/components/Markdown/index.tsx
@@ -19,7 +19,7 @@ const md: MarkdownIt = new MarkdownIt({
     try {
       hl = Prism.highlight(str, Prism.languages[lang], lang)
     } catch (error: any) {
-      logger(`Error highlighing markdown: ${error.message}`)
+      logger(`Error highlighting markdown: ${error.message}`)
       hl = md.utils.escapeHtml(str)
     }
 
@@ -67,7 +67,7 @@ const Markdown = (props: Props) => {
   } catch (error) {
     const message = `Failed to parse markdown for ${props.children}`
     // TODO: onError(new Error(message))
-    logger(message)
+    logger(`Error: ${message}`)
     html = `<div style='background-color: #FFB81A; padding: 0.5rem;'>
 			<strong style='padding-bottom: 0.5rem;'>ERROR: Failed to parse markdown</strong>
 			<p>${props.children}</p>
diff --git a/web-app/src/components/Router/index.tsx b/web-app/src/components/Router/index.tsx
@@ -42,7 +42,7 @@ export const Router = ({ children, route }: RouterProps) => {
   }
   const message = `No Route matches for "${JSON.stringify(route)}"`
   // TODO: onError(new Error(message))
-  logger(message)
+  logger(`Error: ${message}`)
   return null
 }
 

Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,7 @@ export const createCommands = (commandProps: CreateCommandProps): { [key: string`
`75`	`75`	`}`
`76`	`76`	`testRunner = createTestRunner(data, {`
`77`	`77`	`onSuccess: (position: T.Position) => {`
`78`		`- logger('test pass position', position)`
	`78`	+ logger(`Test pass position: ${JSON.stringify(position)}`)
`79`	`79`	`// send test pass message back to client`
`80`	`80`	`channel.context.position.set({ ...position, complete: true })`
`81`	`81`	`send({ type: 'TEST_PASS', payload: { position: { ...position, complete: true } } })`
Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,7 @@ export async function saveCommit(message: string): Promise<never \| void> {`
`53`	`53`	logger(`Error: ${stderr}`)
`54`	`54`	`throw new Error('Error saving progress to Git')`
`55`	`55`	`}`
`56`		`- logger(stdout)`
	`56`	+ logger(`Commit saved: ${stdout}`)
`57`	`57`	`}`
`58`	`58`
`59`	`59`	`export async function clear(): Promise<Error \| void> {`
Original file line number	Diff line number	Diff line change
`@@ -31,14 +31,12 @@ export const deactivate = (): void => {`
`31`	`31`	`}`
`32`	`32`
`33`	`33`	`export const onError = (error: Error, properties?: Properties, measurements?: Measurements): void => {`
`34`		`- logger(error, properties, measurements)`
`35`	`34`	`if (reporter) {`
`36`	`35`	`reporter.sendTelemetryException(error, properties, measurements)`
`37`	`36`	`}`
`38`	`37`	`}`
`39`	`38`
`40`	`39`	`export const onEvent = (eventName: string, properties?: Properties, measurements?: Measurements): void => {`
`41`		`- logger(eventName, properties, measurements)`
`42`	`40`	`if (reporter) {`
`43`	`41`	`reporter.sendTelemetryEvent(eventName, properties, measurements)`
`44`	`42`	`}`
Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ export const Router = ({ children, route }: RouterProps) => {`
`42`	`42`	`}`
`43`	`43`	const message = `No Route matches for "${JSON.stringify(route)}"`
`44`	`44`	`// TODO: onError(new Error(message))`
`45`		`- logger(message)`
	`45`	+ logger(`Error: ${message}`)
`46`	`46`	`return null`
`47`	`47`	`}`
`48`	`48`