locutusjs#344 fixing issue with delete keyword (locutusjs#346)

Oleg Andreyev · kvz · commit 59f0e7356219 · 2017-08-24T16:04:46.000+02:00
diff --git a/src/php/array/array_multisort.js b/src/php/array/array_multisort.js
@@ -1,6 +1,7 @@
 module.exports = function array_multisort (arr) { // eslint-disable-line camelcase
   //  discuss at: http://locutus.io/php/array_multisort/
   // original by: Theriault (https://github.com/Theriault)
+  // improved by: Oleg Andreyev (https://github.com/oleg-andreyev)
   //   example 1: array_multisort([1, 2, 1, 2, 1, 2], [1, 2, 3, 4, 5, 6])
   //   returns 1: true
   //   example 2: var $characters = {A: 'Edward', B: 'Locke', C: 'Sabin', D: 'Terra', E: 'Edward'}
@@ -182,8 +183,8 @@ module.exports = function array_multisort (arr) { // eslint-disable-line camelca
             args[i][vkey] = sortArrs[i][j]
           }
         }
-        delete sortArrs[i]
-        delete sortKeys[i]
+        sortArrs.splice(i, 1)
+        sortKeys.splice(i, 1)
         continue
       }
 
@@ -294,8 +295,8 @@ module.exports = function array_multisort (arr) { // eslint-disable-line camelca
           args[i][vkey] = sortArrs[i][j]
         }
       }
-      delete sortArrs[i]
-      delete sortKeys[i]
+      sortArrs.splice(i, 1)
+      sortKeys.splice(i, 1)
     }
   }
   return true

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,7 @@`
`1`	`1`	`module.exports = function array_multisort (arr) { // eslint-disable-line camelcase`
`2`	`2`	`// discuss at: http://locutus.io/php/array_multisort/`
`3`	`3`	`// original by: Theriault (https://github.com/Theriault)`
	`4`	`+ // improved by: Oleg Andreyev (https://github.com/oleg-andreyev)`
`4`	`5`	`// example 1: array_multisort([1, 2, 1, 2, 1, 2], [1, 2, 3, 4, 5, 6])`
`5`	`6`	`// returns 1: true`
`6`	`7`	`// example 2: var $characters = {A: 'Edward', B: 'Locke', C: 'Sabin', D: 'Terra', E: 'Edward'}`
`@@ -182,8 +183,8 @@ module.exports = function array_multisort (arr) { // eslint-disable-line camelca`
`182`	`183`	`args[i][vkey] = sortArrs[i][j]`
`183`	`184`	`}`
`184`	`185`	`}`
`185`		`- delete sortArrs[i]`
`186`		`- delete sortKeys[i]`
	`186`	`+ sortArrs.splice(i, 1)`
	`187`	`+ sortKeys.splice(i, 1)`
`187`	`188`	`continue`
`188`	`189`	`}`
`189`	`190`
`@@ -294,8 +295,8 @@ module.exports = function array_multisort (arr) { // eslint-disable-line camelca`
`294`	`295`	`args[i][vkey] = sortArrs[i][j]`
`295`	`296`	`}`
`296`	`297`	`}`
`297`		`- delete sortArrs[i]`
`298`		`- delete sortKeys[i]`
	`298`	`+ sortArrs.splice(i, 1)`
	`299`	`+ sortKeys.splice(i, 1)`
`299`	`300`	`}`
`300`	`301`	`}`
`301`	`302`	`return true`