crypto: fix error message buffer overrun

bnoordhuis · bnoordhuis · commit 9ef962f9ee82 · 2011-09-22T06:16:34.000+02:00
ERR_error_string() expects a buffer of at least 256 bytes, the input buffer
was not even half that size. Use ERR_error_string_n() instead.
diff --git a/src/node_crypto.cc b/src/node_crypto.cc
@@ -316,7 +316,7 @@ Handle<Value> SecureContext::SetCert(const Arguments& args) {
           String::New("SSL_CTX_use_certificate_chain")));
     }
     char string[120];
-    ERR_error_string(err, string);
+    ERR_error_string_n(err, string, sizeof string);
     return ThrowException(Exception::Error(String::New(string)));
   }
 

Original file line number	Diff line number	Diff line change
`@@ -316,7 +316,7 @@ Handle<Value> SecureContext::SetCert(const Arguments& args) {`
`316`	`316`	`String::New("SSL_CTX_use_certificate_chain")));`
`317`	`317`	`}`
`318`	`318`	`char string[120];`
`319`		`- ERR_error_string(err, string);`
	`319`	`+ ERR_error_string_n(err, string, sizeof string);`
`320`	`320`	`return ThrowException(Exception::Error(String::New(string)));`
`321`	`321`	`}`
`322`	`322`