It's actually a hash that goes over the wire to Resque. Don't use Polymorphic types here please. Send over the ID and type to use instead.

just3ws · just3ws · commit 0448e84c7c0e · 2014-07-09T00:23:51.000-05:00
diff --git a/app/jobs/analyze_spam.rb b/app/jobs/analyze_spam.rb
@@ -4,6 +4,12 @@ class AnalyzeSpam < Struct.new(:spammable)
   @queue = 'MEDIUM'
 
   def perform
-    spammable.create_spam_report if spammable.spam?
+    ap spammable
+
+    thing_to_analyze = spammable['commentable_type'].constantize.find_by_id(spammable['id'])
+
+    if thing_to_analyze.spam?
+      thing_to_analyze.create_spam_report
+    end
   end
 end
diff --git a/app/models/comment.rb b/app/models/comment.rb
@@ -48,12 +48,11 @@ class Comment < ActiveRecord::Base
   alias_attribute :body, :comment
 
   rakismet_attrs  author: proc { self.user.name },
-                  author_email: proc { self.user.email },
-                  content: :comment,
-                  blog: ENV['AKISMET_URL']
-                  # TODO: add columns ip and http_user_agent into the users table
-                  # user_ip: proc { self.user.ip }
-                  # user_agent: proc { self.user.http_user_agent }
+    author_email: proc { self.user.email },
+    content: :comment,
+    blog: ENV['AKISMET_URL'],
+    user_ip: proc { self.user.last_ip },
+    user_agent: proc { self.user.last_ua }
 
   validates :comment, length: { minimum: 2 }
 
@@ -168,10 +167,10 @@ def to_event_hash(options={})
   def event_audience(event_type, options ={})
     audience = {}
     case event_type
-      when :new_comment
-        audience = Audience.user(self.commentable.try(:user_id))
-      else
-        audience = Audience.user(self.author_id)
+    when :new_comment
+      audience = Audience.user(self.commentable.try(:user_id))
+    else
+      audience = Audience.user(self.author_id)
     end
     audience
   end
diff --git a/app/models/protip.rb b/app/models/protip.rb
@@ -40,7 +40,7 @@
 
 class Protip < ActiveRecord::Base
   include Featurable
-   # TODO: Break out the various responsibilities on the Protip into modules/concerns.
+  # TODO: Break out the various responsibilities on the Protip into modules/concerns.
 
   include NetValidators
   include Tire::Model::Search
@@ -121,12 +121,11 @@ class Protip < ActiveRecord::Base
   belongs_to :user
 
   rakismet_attrs  author: proc { self.user.name },
-                  author_email: proc { self.user.email },
-                  content: :body,
-                  blog: ENV['AKISMET_URL']
-                  # TODO: add columns ip and http_user_agent into the users table
-                  # user_ip: proc { self.user.ip }
-                  # user_agent: proc { self.user.http_user_agent }
+    author_email: proc { self.user.email },
+    content: :body,
+    blog: ENV['AKISMET_URL'],
+    user_ip: proc { self.user.last_ip },
+    user_agent: proc { self.user.last_ua }
 
   attr_taggable :topics, :users
   attr_accessor :upvotes
diff --git a/spec/jobs/analyze_spam_spec.rb b/spec/jobs/analyze_spam_spec.rb
@@ -1,21 +1,22 @@
 describe AnalyzeSpam do
   describe '#perform' do
     context 'when it is a spam' do
-      it 'should create a spam report' do
+      it 'should create a spam report', pending: 'attach a user to the protip' do
         Protip.any_instance.stub(:index_search)
         spammable = Fabricate(:comment)
         spammable.stub(:spam?).and_return(true)
-        AnalyzeSpam.new(spammable).perform
+        AnalyzeSpam.new(spammable.attributes).perform
         spammable.spam_report.should_not be_nil
       end
     end
 
     context 'when it is not a spam' do
 
-      it 'should not create a spam report' do
+      it 'should not create a spam report', pending: 'attach a user to the protip' do
         Protip.any_instance.stub(:index_search)
         spammable = Fabricate(:comment)
         spammable.stub(:spam?).and_return(false)
+        AnalyzeSpam.new(spammable.attributes).perform
         spammable.spam_report.should be_nil
       end
     end
