Added worker and schedule for running the popular protips emailer

just3ws · just3ws · commit 1592cd204bf2 · 2014-08-26T00:42:46.000-05:00
diff --git a/app/clock.rb b/app/clock.rb
@@ -15,6 +15,12 @@
   RefreshStaleUsersWorker.perform_async
 end
 
+# On the first of every month send the popular protips from the previous month.
+every(1.day, 'protip_mailer:popular_protips', if: ->(t){ t.day == 1 }) do
+  last_month = 1.month.ago
+  ProtipMailerPopularProtipsWorker.perform_async(last_month.beginning_of_month, last_month.end_of_month)
+end
+
 every(1.day, 'cleanup:protips:associate_zombie_upvotes', at: '00:00') {}
 every(1.day, 'clear_expired_sessions', at: '00:00') {}
 every(1.day, 'facts:system', at: '00:00') {}
diff --git a/app/mailers/protip_mailer.rb b/app/mailers/protip_mailer.rb
@@ -16,11 +16,16 @@ class ProtipMailer < ActionMailer::Base
     endorsements: 'endorsements',
     protips_count: 'protips'
   }
+  ACTIVITY_SUBJECT_PREFIX = '[Coderwall]'
 
   #################################################################################
   def popular_protips(user, protips, from, to)
-    fail "Protips are required." if protips.nil? || protips.empty?
-    headers['X-Mailgun-Campaign-Id'] = 'coderwall-popular_protips'
+    fail 'Protips are required.' if protips.nil? || protips.empty?
+    fail 'User is required.' unless user
+    fail 'From date is required.' unless from
+    fail 'To date is required.' unless to
+
+    headers['X-Mailgun-Campaign-Id'] = 'protip_mailer-popular_protips'
 
     @user = user
     @protips = protips
@@ -31,13 +36,21 @@ def popular_protips(user, protips, from, to)
     @star_stat = star_stat_for_this_week
     @star_stat_string = STARS[@star_stat]
 
-    @most = star_stats(stars).sort_by { |star| -star[@star_stat] }.first
+    @most = star_stats(stars).sort_by do |star|
+      -star[@star_stat]
+    end.first
     @most = nil if @most && (@most[@star_stat] <= 0)
 
-    mail to: 'mike@just3ws.com', subject: 'Popular Protips on Coderwall'
+    mail(to: @user.email, subject: "#{ACTIVITY_SUBJECT_PREFIX} Popular Protips on Coderwall")
+  rescue Exception => ex
+    abort_delivery(ex)
   end
   #################################################################################
 
+  def abort_delivery(ex)
+    Rails.logger.error("[ProtipMailer.popular_protips] Aborted email '#{ex}' >>\n#{ex.backtrace.join("\n  ")}")
+  end
+
   def campaign_params
     {
       utm_campaign: 'coderwall-popular_protips',
@@ -65,7 +78,7 @@ def get_team_and_job_for(user)
       teams = teams_for_user(user)
       teams.each do |team|
         best_job = team.best_positions_for(user).detect do |job|
-          (job.team_document_id == user.team_document_id) || !already_sent?(job, user)
+          job.team_document_id == user.team_document_id
         end
         return [team, best_job] unless best_job.nil?
       end
@@ -79,16 +92,12 @@ def teams_for_user(user)
     end
   end
 
-  def already_sent?(mailable, user)
-    SentMail.where(user_id: user.id, mailable_id: mailable.id, mailable_type: mailable.class.name).exists?
-  end
-
   module Queries
     def self.popular_protips(from, to)
       search_results = ProtipMailer::Queries.search_for_popular_protips(from, to)
       public_ids = search_results.map { |protip| protip['public_id'] }
 
-      Protip.eager_load(:user, :comments).where("public_id in (?)", public_ids)
+      Protip.eager_load(:user, :comments).where('public_id in (?)', public_ids)
     end
 
     def self.search_for_popular_protips(from, to, max_results=10)
diff --git a/app/workers/protip_mailer_popular_protips_worker.rb b/app/workers/protip_mailer_popular_protips_worker.rb
@@ -0,0 +1,12 @@
+class ProtipMailerPopularProtipsWorker
+  include Sidekiq::Worker
+  sidekiq_options queue: :low
+
+  def perform(from, to)
+    protips = ProtipMailer::Queries.popular_protips(from, to)
+
+    User.find_each(batch_size: 100) do |user|
+      ProtipMailer.popular_protips(user, protips, from, to).deliver
+    end
+  end
+end
