fix Protip#topic_ids

rohitpaulk · rohitpaulk · commit 311cafe4b9a0 · 2015-01-01T01:35:36.000+05:30
#topic_ids was returning ids of both the topics and the tagged user.
diff --git a/app/models/protip.rb b/app/models/protip.rb
@@ -403,7 +403,7 @@ def event_type(options={})
   end
 
   def topic_ids
-    self.taggings.joins('inner join tags on taggings.tag_id = tags.id').select('tags.id').map(&:id)
+    topics_tags.pluck(:id)
   end
 
   def to_indexed_json
diff --git a/spec/models/protip_spec.rb b/spec/models/protip_spec.rb
@@ -126,6 +126,14 @@
       expect(protip.topics).to eq(%w(ruby python heroku))
       expect(protip.topics.count).to eq(3)
     end
+
+    it '#topic_ids should return ids of topics only' do
+      protip = Fabricate(:protip, topics: 'ruby python', user: Fabricate(:user))
+      protip.save!
+      ruby_id = Tag.find_by_name("ruby").id
+      python_id = Tag.find_by_name("python").id
+      expect(protip.topic_ids).to match_array([ruby_id, python_id])
+    end
   end
 
   describe 'linking and featuring an image' do
