Skip to content

Commit 3c61d76

Browse files
committed
Ensure that the spammable class is formatted correctly before constantizing. Cleaned out the old logging noise
1 parent b9fe0f8 commit 3c61d76

File tree

1 file changed

+3
-7
lines changed

1 file changed

+3
-7
lines changed

app/jobs/analyze_spam.rb

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,19 +5,15 @@ class AnalyzeSpam < Struct.new(:spammable)
55

66
def perform
77

8-
ap(spammable) unless Rails.env.test?
9-
108
spammable.symbolize_keys!
119

12-
thing_to_analyze = spammable[:klass].constantize.find(spammable[:id])
13-
14-
ap(thing_to_analyze) unless Rails.env.test?
10+
thing_to_analyze = spammable[:klass].classify.constantize.find(spammable[:id])
1511

1612
if thing_to_analyze.spam?
17-
puts("#{spammable[:klass]} with id #{spammable[:id]} was spam") unless Rails.env.test?
13+
puts("#{spammable[:klass]} with id #{spammable[:id]} was spam") if ENV['DEBUG']
1814
thing_to_analyze.create_spam_report
1915
else
20-
puts("#{spammable[:klass]} with id #{spammable[:id]} was NOT spam") unless Rails.env.test?
16+
puts("#{spammable[:klass]} with id #{spammable[:id]} was NOT spam") if ENV['DEBUG']
2117
end
2218
end
2319
end

0 commit comments

Comments
 (0)