Merge pull request #72 from assemblymade/lookup_protip_downcase_nil

just3ws · just3ws · commit a5d2bd486bfe · 2014-07-18T23:37:31.000-05:00
Only lookup_protip on controller if the param :id is present
diff --git a/app/controllers/protips_controller.rb b/app/controllers/protips_controller.rb
@@ -430,7 +430,11 @@ def expand_query(query_string)
   end
 
   def lookup_protip
-    @protip = Protip.find_by_public_id(params.permit(:id)[:id].downcase)
+    @protip = if public_id = params[:id]
+                Protip.find_by_public_id(public_id.downcase)
+              else
+                nil
+              end
   end
 
   def choose_protip_layout
