Remove space as a delimiter for tags

rohitpaulk · rohitpaulk · commit ac2cb8809963 · 2015-01-01T21:06:25.000+05:30
Space is no longer used as a delimiter anywhere in the codebase. Updated specs. minor fixes
diff --git a/app/controllers/protips_controller.rb b/app/controllers/protips_controller.rb
@@ -316,7 +316,7 @@ def feature
   end
 
   def delete_tag
-    @protip.topic_list.remove(CGI.unescape(params.permit(:topic)))
+    @protip.topic_list.remove(params.permit(:topic))
     respond_to do |format|
       if @protip.save
         format.html { redirect_to protip_path(@protip) }
diff --git a/app/models/network.rb b/app/models/network.rb
@@ -17,7 +17,7 @@ class Network < ActiveRecord::Base
       profile_url:  { type: 'string', index: 'not_analyzed' },
     } } } }
 
-  acts_as_taggable_on :tags
+  acts_as_taggable
   acts_as_followable
   attr_accessor :resident_expert
   has_many :network_experts, autosave: true, dependent: :destroy
diff --git a/app/models/opportunity.rb b/app/models/opportunity.rb
@@ -6,7 +6,7 @@ class Opportunity < ActiveRecord::Base
   include SearchModule
   include OpportunityMapping
 
-  acts_as_taggable_on :tags
+  acts_as_taggable
 
   OPPORTUNITY_TYPES = %w(full-time part-time contract internship)
 
diff --git a/config/initializers/acts_as_taggable_on.rb b/config/initializers/acts_as_taggable_on.rb
@@ -1,3 +1 @@
-# Replace this with default parser before upgrading to AATO 4.0+
-ActsAsTaggableOn.delimiter = [' ', ',']
 ActsAsTaggableOn.force_lowercase = true
diff --git a/spec/fabricators/opportunity_fabricator.rb b/spec/fabricators/opportunity_fabricator.rb
@@ -2,7 +2,7 @@
   salary 100_000
   name 'Senior Rails Web Developer'
   description 'Architect and implement the Ruby and Javascript underpinnings of our various user-facing and internal web apps like api.heroku.com.'
-  tag_list ['rails', 'sinatra', 'JQuery', 'Clean, beautiful code']
+  tag_list ['rails', 'sinatra', 'JQuery']
   location 'San Francisco, CA'
   cached_tags 'java, python'
   team_id { Fabricate(:team, paid_job_posts: 1).id }
diff --git a/spec/models/protip_spec.rb b/spec/models/protip_spec.rb
@@ -120,15 +120,15 @@
       expect(protip.topics.count).to eq(1)
     end
 
-    it 'should accept tags separated by spaces only' do
-      protip = Fabricate(:protip, topic_list: 'ruby python heroku', user: Fabricate(:user))
+    it 'should accept tags separated by commas only' do
+      protip = Fabricate(:protip, topic_list: 'ruby, python, heroku', user: Fabricate(:user))
       protip.save!
       expect(protip.topic_list).to eq(%w(ruby python heroku))
       expect(protip.topics.count).to eq(3)
     end
 
     it '#topic_ids should return ids of topics only' do
-      protip = Fabricate(:protip, topic_list: 'ruby python', user: Fabricate(:user))
+      protip = Fabricate(:protip, topic_list: 'ruby, python', user: Fabricate(:user))
       protip.save!
       ruby_id = Tag.find_by_name("ruby").id
       python_id = Tag.find_by_name("python").id

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1 @@`
`1`		`-# Replace this with default parser before upgrading to AATO 4.0+`
`2`		`-ActsAsTaggableOn.delimiter = [' ', ',']`
`3`	`1`	`ActsAsTaggableOn.force_lowercase = true`