fixed list current user team permission bug and permission editing bug

fomalhautb · fomalhautb · commit 0c31d6a9ff53 · 2024-08-03T15:46:37.000-07:00
diff --git a/apps/dashboard/src/components/data-table/team-member-table.tsx b/apps/dashboard/src/components/data-table/team-member-table.tsx
@@ -82,7 +82,7 @@ function EditPermissionDialog(props: {
       const promises = permissions.map(p => {
         if (values.permissions.includes(p.id)) {
           return props.user.grantPermission(props.team, p.id);
-        } else {
+        } else if (props.user.permissions.includes(p.id)) {
           return props.user.revokePermission(props.team, p.id);
         }
       });
diff --git a/packages/stack-shared/src/interface/clientInterface.ts b/packages/stack-shared/src/interface/clientInterface.ts
@@ -786,7 +786,7 @@ export class StackClientInterface {
     session: InternalSession
   ): Promise<TeamPermissionsCrud['Client']['Read'][]> {
     const response = await this.sendClientRequest(
-      `/team-permissions?team_id=${options.teamId}?user_id=me&recursive=${options.recursive}`,
+      `/team-permissions?team_id=${options.teamId}&user_id=me&recursive=${options.recursive}`,
       {},
       session,
     );

Original file line number	Diff line number	Diff line change
`@@ -82,7 +82,7 @@ function EditPermissionDialog(props: {`
`82`	`82`	`const promises = permissions.map(p => {`
`83`	`83`	`if (values.permissions.includes(p.id)) {`
`84`	`84`	`return props.user.grantPermission(props.team, p.id);`
`85`		`- } else {`
	`85`	`+ } else if (props.user.permissions.includes(p.id)) {`
`86`	`86`	`return props.user.revokePermission(props.team, p.id);`
`87`	`87`	`}`
`88`	`88`	`});`