Skip to content

Commit b80f5ea

Browse files
committed
clean up PR policy, add notes on buildbot
1 parent 27ba398 commit b80f5ea

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

pull-request-policy.md

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ title: Pull Request Policy
66
Hi there, pull request submitter!
77

88
Your pull request should:
9+
910
- (... have been discussed on scala-internals)
1011
- merge cleanly
1112
- consist of commits with impeccable commit messages
@@ -34,10 +35,13 @@ we will merge your changes.
3435
Please note: you are responsible for meeting these criteria (reminding your reviewer, for example).
3536

3637
### Pull request bot mechanics
37-
* most of this will be automated, but in the mean time, please consider the following:
38-
* when you push new commits, please delete the comments with the old build results to avoid confusion (this will also trigger a new build, even though the bot detects this automatically)
39-
* label the issue corresponding to your pull request (if you have permission) as 'tested' when the bot has reported on a successful build, 'reviewed' when everyone has LGTM'd
40-
* 'PLS REBUILD ALL' will force the bot to rebuild (handy for spurious failures)
38+
Please see the [pr validator's overview](https://github.com/typesafehub/ghpullrequest-validator/blob/master/overview.md) for details.
39+
40+
Quick notes:
41+
42+
* The bot automatically builds every commit as it is added to the PR, and will set the status according to the results of the test suite (click on the indicator to see the build log).
43+
* The bot will add the 'reviewed' label if there's a comment starting with "LGTM".
44+
* 'PLS REBUILD ALL' is only necessary when something other than the commit is causing a failure
4145

4246
### List of reviewers by area:
4347

0 commit comments

Comments
 (0)