Drain NSAutoreleasePools instead of releasing them.

rpendleton · rpendleton · commit 21bf1c34c200 · 2011-12-11T19:03:54.000-07:00
Releasing objects is a no-op in garbage collected environments, so
draining them is the preferred method.
diff --git a/RunLoop/AsyncSocket.m b/RunLoop/AsyncSocket.m
@@ -4291,7 +4291,7 @@ static void MyCFSocketCallback (CFSocketRef sref, CFSocketCallBackType type, CFD
 	AsyncSocket *theSocket = [[(AsyncSocket *)pInfo retain] autorelease];
 	[theSocket doCFSocketCallback:type forSocket:sref withAddress:(NSData *)address withData:pData];
 	
-	[pool release];
+	[pool drain];
 }
 
 /**
@@ -4305,7 +4305,7 @@ static void MyCFReadStreamCallback (CFReadStreamRef stream, CFStreamEventType ty
 	AsyncSocket *theSocket = [[(AsyncSocket *)pInfo retain] autorelease];
 	[theSocket doCFReadStreamCallback:type forStream:stream];
 	
-	[pool release];
+	[pool drain];
 }
 
 /**
@@ -4319,7 +4319,7 @@ static void MyCFWriteStreamCallback (CFWriteStreamRef stream, CFStreamEventType
 	AsyncSocket *theSocket = [[(AsyncSocket *)pInfo retain] autorelease];
 	[theSocket doCFWriteStreamCallback:type forStream:stream];
 	
-	[pool release];
+	[pool drain];
 }
 
 ////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
diff --git a/RunLoop/AsyncUdpSocket.m b/RunLoop/AsyncUdpSocket.m
@@ -2337,7 +2337,7 @@ static void MyCFSocketCallback(CFSocketRef sref, CFSocketCallBackType type, CFDa
 	AsyncUdpSocket *theSocket = [[(AsyncUdpSocket *)pInfo retain] autorelease];
 	[theSocket doCFSocketCallback:type forSocket:sref withAddress:(NSData *)address withData:pData];
 	
-	[pool release];
+	[pool drain];
 }
 
 @end

Original file line number	Diff line number	Diff line change
`@@ -4291,7 +4291,7 @@ static void MyCFSocketCallback (CFSocketRef sref, CFSocketCallBackType type, CFD`
`4291`	`4291`	`AsyncSocket theSocket = [[(AsyncSocket )pInfo retain] autorelease];`
`4292`	`4292`	`[theSocket doCFSocketCallback:type forSocket:sref withAddress:(NSData *)address withData:pData];`
`4293`	`4293`
`4294`		`- [pool release];`
	`4294`	`+ [pool drain];`
`4295`	`4295`	`}`
`4296`	`4296`
`4297`	`4297`	`/**`
`@@ -4305,7 +4305,7 @@ static void MyCFReadStreamCallback (CFReadStreamRef stream, CFStreamEventType ty`
`4305`	`4305`	`AsyncSocket theSocket = [[(AsyncSocket )pInfo retain] autorelease];`
`4306`	`4306`	`[theSocket doCFReadStreamCallback:type forStream:stream];`
`4307`	`4307`
`4308`		`- [pool release];`
	`4308`	`+ [pool drain];`
`4309`	`4309`	`}`
`4310`	`4310`
`4311`	`4311`	`/**`
`@@ -4319,7 +4319,7 @@ static void MyCFWriteStreamCallback (CFWriteStreamRef stream, CFStreamEventType`
`4319`	`4319`	`AsyncSocket theSocket = [[(AsyncSocket )pInfo retain] autorelease];`
`4320`	`4320`	`[theSocket doCFWriteStreamCallback:type forStream:stream];`
`4321`	`4321`
`4322`		`- [pool release];`
	`4322`	`+ [pool drain];`
`4323`	`4323`	`}`
`4324`	`4324`
`4325`	`4325`	`////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////`
Original file line number	Diff line number	Diff line change
`@@ -2337,7 +2337,7 @@ static void MyCFSocketCallback(CFSocketRef sref, CFSocketCallBackType type, CFDa`
`2337`	`2337`	`AsyncUdpSocket theSocket = [[(AsyncUdpSocket )pInfo retain] autorelease];`
`2338`	`2338`	`[theSocket doCFSocketCallback:type forSocket:sref withAddress:(NSData *)address withData:pData];`
`2339`	`2339`
`2340`		`- [pool release];`
	`2340`	`+ [pool drain];`
`2341`	`2341`	`}`
`2342`	`2342`
`2343`	`2343`	`@end`