Privacy popup #3192
Privacy popup #3192
Conversation
| @@ -47,6 +47,7 @@ export const Centered = styled.div` | |||
| display: flex; | |||
| justify-content: center; | |||
| z-index: 0; /* So pointer events on left and right continue */ | |||
| z-index: 10; /* override: this probably breaks something, not sure what */ | |||
There was a problem hiding this comment.
@CompuIves @christianalfoni Overriding this, what should I be testing for this?
| @@ -94,7 +94,7 @@ const ContentSplit: React.FC = () => { | |||
| right: 0, | |||
| bottom: bottomOffset, | |||
| height: statusBar ? 'auto' : 'calc(100% - 3.5rem)', | |||
| zIndex: 999999, | |||
| zIndex: 9, | |||
There was a problem hiding this comment.
@CompuIves @christianalfoni I'm sure this breaks something, any tips on where should I start looking?
|
|
||
| export const Container = styled.div( | ||
| css({ | ||
| '.tippy-content': { |
There was a problem hiding this comment.
Note: Override tippy design inside this popup. Would be nice when we can move this to common
packages/app/src/app/pages/Sandbox/Editor/Header/PrivacyTooltip/index.tsx
Show resolved
Hide resolved
|
Build for latest commit 2f8aa33 is at https://pr3192.build.csb.dev/s/new. |
|
When I'm not signed in I see this, with the disabled select: Would it make sense to let the user know to sign in or something? Or refer to Pro anyway? |
|
What do you think @DannyRuchtie ? |
|
When seeing the sandbox you don't own there seems to be a margin missing:
|
|
I can change the privacy as a patron, but there is still a message for upgrading to pro, would it make sense to remove it in that case?
|
packages/app/src/app/pages/Sandbox/Editor/Header/PrivacyTooltip/index.tsx
Outdated
Show resolved
Hide resolved
|
@CompuIves Added check for owner which takes care of logged out case as well |
You shouldn't be seeing this as a patron 🤔 The logic is on |
|
The selectbox is not rendering correctly on safari. Also missing the level-1 dropshadow Nice work btw!! |
This reverts commit 19688a5.
Add a way to change privacy of a sandbox - which is a pro feature right now
Design: https://www.figma.com/file/CB73VJsBOHZYiqFYV4NxBS/Go-Pro