chore: updated eslint and ignored underscrore

dastrong-codiga · dastrong-codiga · commit 77e71f8f277e · 2022-09-02T10:15:02.000-07:00
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -4,14 +4,26 @@ module.exports = {
     // A temporary hack related to IDE not resolving correct package.json
     'import/no-extraneous-dependencies': 'off',
     'import/no-unresolved': 'error',
+    'import/no-cycle': 'off',
+    'import/prefer-default-export': 'off',
     // Since React 17 and typescript 4.1 you can safely disable the rule
     'react/react-in-jsx-scope': 'off',
     'react/jsx-props-no-spreading': 'off',
-    'import/no-cycle': 'off',
-    '@typescript-eslint/no-non-null-assertion': 'off',
     'react/require-default-props': [2, { functions: 'defaultArguments' }],
-    'import/prefer-default-export': 'off',
+    '@typescript-eslint/no-non-null-assertion': 'off',
     '@typescript-eslint/ban-ts-comment': 'off',
+    '@typescript-eslint/no-unused-vars': [
+      'error',
+      {
+        argsIgnorePattern: '^_',
+        varsIgnorePattern: '^_',
+        caughtErrorsIgnorePattern: '^_',
+      },
+    ],
+    '@typescript-eslint/naming-convention': [
+      'error',
+      { leadingUnderscore: 'allow' },
+    ],
   },
   parserOptions: {
     ecmaVersion: 2020,
diff --git a/src/renderer/components/Layout/SideMenu.tsx b/src/renderer/components/Layout/SideMenu.tsx
@@ -107,6 +107,7 @@ export default function SideMenu({ openLoginModal }: SideMenuProps) {
                 navigate('/');
                 await apolloClient.resetStore();
               } catch (err) {
+                // eslint-disable-next-line no-console
                 console.log('Error while logging out: ', err);
               }
             }}
diff --git a/src/renderer/components/ThemeContext/ThemeContext.tsx b/src/renderer/components/ThemeContext/ThemeContext.tsx
@@ -42,8 +42,7 @@ export const ThemeProvider = ({ children }: { children: ReactNode }) => {
   // CHAKRA'S THEME
   const { setColorMode } = useColorMode();
   // USER'S LOCAL THEME PREFERENCE
-  // @ts-ignore
-  const [cacheTheme, cacheStorageTheme, hydrateValue] = useLocalStorage(
+  const [_, cacheStorageTheme, hydrateValue] = useLocalStorage(
     CODIGA_THEME,
     Theme.THEME_LIGHT
   ) as [ThemeType, CacheStorageThemeType, () => string];

Original file line number	Diff line number	Diff line change
`@@ -107,6 +107,7 @@ export default function SideMenu({ openLoginModal }: SideMenuProps) {`
`107`	`107`	`navigate('/');`
`108`	`108`	`await apolloClient.resetStore();`
`109`	`109`	`} catch (err) {`
	`110`	`+ // eslint-disable-next-line no-console`
`110`	`111`	`console.log('Error while logging out: ', err);`
`111`	`112`	`}`
`112`	`113`	`}}`