Skip to content

Commit 09021aa

Browse files
committed
Adding LONG to list of numeric types, updating TODO
1 parent 26c7251 commit 09021aa

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

TODO.md

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,6 @@
11
# TODO
22
List of TODO items for Dashed
33

4-
range filter formatter
5-
sankey example is missing
6-
74
## Important
85
* **Getting proper JS testing:** unit tests on the Python side are pretty
96
solid, but now we need a test suite for the JS part of the site,
@@ -39,6 +36,8 @@ sankey example is missing
3936

4037

4138
## Easy-ish fix
39+
* Build matrix to include mysql using tox
40+
* Figure out why coverage isn't working
4241
* Kill switch for Druid in docs
4342
* CREATE VIEW button from SQL editor
4443
* Test button for when editing SQL expression

dashed/models.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -634,7 +634,7 @@ def fetch_metadata(self):
634634
db.session.flush()
635635
if not dbcol:
636636
dbcol = TableColumn(column_name=col.name)
637-
num_types = ('DOUBLE', 'FLOAT', 'INT', 'BIGINT')
637+
num_types = ('DOUBLE', 'FLOAT', 'INT', 'BIGINT', 'LONG')
638638
datatype = str(datatype).upper()
639639
if (
640640
str(datatype).startswith('VARCHAR') or

0 commit comments

Comments
 (0)