Refactors Excel cell opening logic

Sébastien Geiser · Sébastien Geiser · commit f9a9bd9a06ed · 2025-05-05T13:39:25.000+02:00
Consolidates the logic for opening a specific cell in Excel into a dedicated method.

This improves code readability and reduces duplication in the event handlers.
diff --git a/RegexDialog/RegExToolDialog.xaml.cs b/RegexDialog/RegExToolDialog.xaml.cs
@@ -12,7 +12,6 @@
 using System.Collections.Generic;
 using System.Collections.ObjectModel;
 using System.Diagnostics;
-using System.Globalization;
 using System.IO;
 using System.Linq;
 using System.Reflection;
@@ -1389,21 +1388,7 @@ private void TreeViewItem_MouseDoubleClick(object sender, MouseButtonEventArgs e
                     }
                     else if(Config.Instance.TextSourceOn == RegexTextSource.Excel)
                     {
-                        var searchResult = regexResult;
-                        RegexExcelSheetResult excelSheetResult = null;
-
-                        while (searchResult != null)
-                        {
-                            if(searchResult is RegexExcelSheetResult)
-                                excelSheetResult = (RegexExcelSheetResult)searchResult;
-                            searchResult = searchResult.Parent;
-                        }
-
-                        if (excelSheetResult != null)
-                        {
-                            string launchExcelVbsScriptPath = Path.Combine(Path.GetDirectoryName(Assembly.GetExecutingAssembly().Location), "LaunchExcelVbsScript.vbs");
-                            Process.Start(launchExcelVbsScriptPath, $"\"{Config.Instance.TextSourceExcelPath}\" \"{excelSheetResult.SheetName}\" \"{regexResult.InfoSup}\"");
-                        }
+                        OpenCellInExcel(regexResult);
                     }
 
                     e.Handled = true;
@@ -1430,28 +1415,33 @@ private void TreeViewItem_KeyDown(object sender, KeyEventArgs e)
                     }
                     else if (Config.Instance.TextSourceOn == RegexTextSource.Excel)
                     {
-                        var searchResult = regexResult;
-                        RegexExcelSheetResult excelSheetResult = null;
-
-                        while (searchResult != null)
-                        {
-                            if (searchResult is RegexExcelSheetResult)
-                                excelSheetResult = (RegexExcelSheetResult)searchResult;
-                            searchResult = searchResult.Parent;
-                        }
-
-                        if (excelSheetResult != null)
-                        {
-                            string launchExcelVbsScriptPath = Path.Combine(Path.GetDirectoryName(Assembly.GetExecutingAssembly().Location), "LaunchExcelVbsScript.vbs");
-                            Process.Start(launchExcelVbsScriptPath, $"\"{Config.Instance.TextSourceExcelPath}\" \"{excelSheetResult.SheetName}\" \"{regexResult.InfoSup}\"");
-                        }
+                        OpenCellInExcel(regexResult);
                     }
 
                     e.Handled = true;
                 }
             }
             catch { }
         }
+        
+        private void OpenCellInExcel(RegexResult regexResult)
+        {
+            var searchResult = regexResult;
+            RegexExcelSheetResult excelSheetResult = null;
+
+            while (searchResult != null)
+            {
+                if (searchResult is RegexExcelSheetResult result)
+                    excelSheetResult = result;
+                searchResult = searchResult.Parent;
+            }
+
+            if (excelSheetResult != null)
+            {
+                string launchExcelVbsScriptPath = Path.Combine(Path.GetDirectoryName(Assembly.GetExecutingAssembly().Location), "LaunchExcelVbsScript.vbs");
+                Process.Start(launchExcelVbsScriptPath, $"\"{Config.Instance.TextSourceExcelPath}\" \"{excelSheetResult.SheetName}\" \"{regexResult.InfoSup}\"");
+            }
+        }
 
         private void RegexLanguageElement_StackPanel_MouseDown(object sender, MouseButtonEventArgs e)
         {
