From 7b6ebb398c89459ffe479d519ee5a69db2449ae9 Mon Sep 17 00:00:00 2001 From: JeanGarf Date: Fri, 28 Feb 2020 14:34:00 +0100 Subject: [PATCH] Fixes #586 : Remove content of AccountsActivity.AccountViewPagerAdapter.destroyItem() to avoid app crash when opening another book after switching to Recent or Favorites Accounts Tab --- .../org/gnucash/android/ui/account/AccountsActivity.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/app/src/main/java/org/gnucash/android/ui/account/AccountsActivity.java b/app/src/main/java/org/gnucash/android/ui/account/AccountsActivity.java index 5e8a94026..9d62bb1dd 100644 --- a/app/src/main/java/org/gnucash/android/ui/account/AccountsActivity.java +++ b/app/src/main/java/org/gnucash/android/ui/account/AccountsActivity.java @@ -176,8 +176,9 @@ public Fragment getItem(int i) { @Override public void destroyItem(ViewGroup container, int position, Object object) { - super.destroyItem(container, position, object); - mFragmentPageReferenceMap.remove(position); + // #586 By putting this in comment, there is no more crash, but I don't know if there are side effects +// super.destroyItem(container, position, object); +// mFragmentPageReferenceMap.remove(position); } @Override