Merge pull request #1377 from msebolt/walkthrough-review-pr3

v-shils · web-flow · commit 7ad24e818e8e · 2018-09-24T11:07:50.000-07:00
walkthrough fix
diff --git a/docs/windows/codesnippet/CSharp/walkthrough-creating-a-windows-store-app-using-wrl-and-media-foundation_8.cs b/docs/windows/codesnippet/CSharp/walkthrough-creating-a-windows-store-app-using-wrl-and-media-foundation_8.cs
@@ -1,6 +1,7 @@
 using System;
 using Windows.Devices.Enumeration;
 using Windows.Media.Capture;
+using Windows.Media.Effects;
 using Windows.Media.MediaProperties;
 using Windows.Storage.Streams;
 using Windows.UI;
@@ -110,7 +111,8 @@ private async void AddRemoveEffect_Checked(object sender, RoutedEventArgs e)
             try
             {
                 AddRemoveEffect.IsEnabled = false;
-                await mediaCapture.AddEffectAsync(MediaStreamType.Photo, "GrayscaleTransform.GrayscaleEffect", null);
+                VideoEffectDefinition def = new VideoEffectDefinition("GrayscaleTransform.GrayscaleEffect");
+                await mediaCapture.AddVideoEffectAsync(def, MediaStreamType.Photo);
                 ShowStatusMessage("Add effect to video preview successful");
                 AddRemoveEffect.IsEnabled = true;
             }
diff --git a/docs/windows/walkthrough-creating-a-windows-store-app-using-wrl-and-media-foundation.md b/docs/windows/walkthrough-creating-a-windows-store-app-using-wrl-and-media-foundation.md
@@ -19,7 +19,7 @@ This example creates a custom Media Foundation transform that applies a grayscal
 > [!NOTE]
 > Instead of C#, you can also use JavaScript, Visual Basic, or C++ to consume the custom transform component.
 
-In most cases, you can use C++/CX to create Windows Runtime). However, sometimes you have to use the WRL. For example, when you create a media extension for Microsoft Media Foundation, you must create a component that implements both COM and Windows Runtime interfaces. Because C++/CX can only create Windows Runtime objects, to create a media extension you must use the WRL because it enables the implementation of both COM and Windows Runtime interfaces.
+In most cases, you can use C++/CX to create Windows Runtime. However, sometimes you have to use the WRL. For example, when you create a media extension for Microsoft Media Foundation, you must create a component that implements both COM and Windows Runtime interfaces. Because C++/CX can only create Windows Runtime objects, to create a media extension you must use the WRL because it enables the implementation of both COM and Windows Runtime interfaces.
 
 > [!NOTE]
 > Although this code example is long, it demonstrates the minimum that's required to create a useful Media Foundation transform. You can use it as a starting point for your own custom transform. This example is adapted from the [Media extensions sample](http://code.msdn.microsoft.com/windowsapps/Media-extensions-sample-7b466096), which uses media extensions to apply effects to video, decode video, and create scheme handlers that produce media streams.
@@ -42,7 +42,7 @@ In most cases, you can use C++/CX to create Windows Runtime). However, sometimes
 
 - The [InspectableClass](../windows/inspectableclass-macro.md) macro implements basic COM functionality such as reference counting and the `QueryInterface` method, and sets the runtime class name and trust level.
 
-- Use the Microsoft::WRL::[Module class](https://www.microsoftonedoc.com/#/organizations/e6f6a65cf14f462597b64ac058dbe1d0/projects/3fedad16-eaf1-41a6-8f96-0c1949c68f32/containers/a3daf831-1c5f-4bbe-964d-503870caf874/tocpaths/b4acf5de-2f4c-4c8b-b5ff-9140d023ecbe/locales/en-US) to implement DLL entry-point functions such as [DllGetActivationFactory](https://msdn.microsoft.com/library/br205771.aspx), [DllCanUnloadNow](/windows/desktop/api/combaseapi/nf-combaseapi-dllcanunloadnow), and [DllGetClassObject](/windows/desktop/api/combaseapi/nf-combaseapi-dllgetclassobject).
+- Use the Microsoft::WRL::[Module class](https://www.microsoftonedoc.com/#/organizations/e6f6a65cf14f462597b64ac058dbe1d0/projects/3fedad16-eaf1-41a6-8f96-0c1949c68f32/containers/a3daf831-1c5f-4bbe-964d-503870caf874/tocpaths/b4acf5de-2f4c-4c8b-b5ff-9140d023ecbe) to implement DLL entry-point functions such as [DllGetActivationFactory](https://msdn.microsoft.com/library/br205771.aspx), [DllCanUnloadNow](/windows/desktop/api/combaseapi/nf-combaseapi-dllcanunloadnow), and [DllGetClassObject](/windows/desktop/api/combaseapi/nf-combaseapi-dllgetclassobject).
 
 - Link your component DLL to runtimeobject.lib. Also specify [/WINMD](../cppcx/compiler-and-linker-options-c-cx.md) on the linker line to generate Windows metadata.
 
@@ -52,29 +52,29 @@ In most cases, you can use C++/CX to create Windows Runtime). However, sometimes
 
 1. In Visual Studio, create a **Blank Solution** project. Name the project, for example, *MediaCapture*.
 
-2. Add a **DLL (Universal Windows)** project to the solution. Name the project, for example, *GrayscaleTransform*.
+1. Add a **DLL (Universal Windows)** project to the solution. Name the project, for example, *GrayscaleTransform*.
 
-3. Add a **Midl File (.idl)** file to the project. Name the file, for example, *GrayscaleTransform.idl*.
+1. Add a **Midl File (.idl)** file to the project. Name the file, for example, *GrayscaleTransform.idl*.
 
-4. Add this code to GrayscaleTransform.idl.
+1. Add this code to GrayscaleTransform.idl:
 
    [!code-cpp[wrl-media-capture#1](../windows/codesnippet/CPP/walkthrough-creating-a-windows-store-app-using-wrl-and-media-foundation_1.idl)]
 
-5. Use the following code to replace the contents of `pch.h`.
+1. Use the following code to replace the contents of `pch.h`:
 
    [!code-cpp[wrl-media-capture#2](../windows/codesnippet/CPP/walkthrough-creating-a-windows-store-app-using-wrl-and-media-foundation_2.h)]
 
-6. Add a new header file to the project, name it `BufferLock.h`, and then add this code:
+1. Add a new header file to the project, name it `BufferLock.h`, and then replace the contents with this code:
 
    [!code-cpp[wrl-media-capture#3](../windows/codesnippet/CPP/walkthrough-creating-a-windows-store-app-using-wrl-and-media-foundation_3.h)]
 
-7. `GrayscaleTransform.h` is not used in this example. You can remove it from the project if you want to.
+1. `GrayscaleTransform.h` is not used in this example. You can remove it from the project if you want to.
 
-8. Use the following code to replace the contents of `GrayscaleTransform.cpp`.
+1. Use the following code to replace the contents of `GrayscaleTransform.cpp`:
 
    [!code-cpp[wrl-media-capture#4](../windows/codesnippet/CPP/walkthrough-creating-a-windows-store-app-using-wrl-and-media-foundation_4.cpp)]
 
-9. Add a new module-definition file to the project, name it `GrayscaleTransform.def`, and then add this code:
+1. Add a new module-definition file to the project, name it `GrayscaleTransform.def`, and then add this code:
 
    ```
    EXPORTS
@@ -83,31 +83,31 @@ In most cases, you can use C++/CX to create Windows Runtime). However, sometimes
        DllGetClassObject                   PRIVATE
    ```
 
-10. Use the following code to replace the contents of `dllmain.cpp`.
+1. Use the following code to replace the contents of `dllmain.cpp`:
 
    [!code-cpp[wrl-media-capture#6](../windows/codesnippet/CPP/walkthrough-creating-a-windows-store-app-using-wrl-and-media-foundation_6.cpp)]
 
-11. In the project’s **Property Pages** dialog box, set the following **Linker** properties.
+1. In the project’s **Property Pages** dialog box, set the following **Linker** properties.
 
    1. Under **Input**, for the **Module Definition File**, specify `GrayScaleTransform.def`.
 
-   2. Also under **Input**, add `runtimeobject.lib`, `mfuuid.lib`, and `mfplat.lib` to the **Additional Dependencies** property.
+   1. Also under **Input**, add `runtimeobject.lib`, `mfuuid.lib`, and `mfplat.lib` to the **Additional Dependencies** property.
 
-   3. Under **Windows Metadata**, set **Generate Windows Metadata** to **Yes (/WINMD)**.
+   1. Under **Windows Metadata**, set **Generate Windows Metadata** to **Yes (/WINMD)**.
 
 ### To use the WRL the custom Media Foundation component from a C# app
 
-1. Add a new **C# Blank App (XAML)** project to the `MediaCapture` solution. Name the project, for example, *MediaCapture*.
+1. Add a new **C# Blank App (Universal Windows)** project to the `MediaCapture` solution. Name the project, for example, *MediaCapture*.
 
-2. In the **MediaCapture** project, add a reference to the `GrayscaleTransform` project. To learn how, see [How to: Add or Remove References By Using the Reference Manager](/visualstudio/ide/how-to-add-or-remove-references-by-using-the-reference-manager).
+1. In the **MediaCapture** project, add a reference to the `GrayscaleTransform` project. To learn how, see [How to: Add or Remove References By Using the Reference Manager](/visualstudio/ide/how-to-add-or-remove-references-by-using-the-reference-manager).
 
-3. In `Package.appxmanifest`, on the **Capabilities** tab, select **Microphone** and **Webcam**. Both capabilities are required to capture photos from the webcam.
+1. In `Package.appxmanifest`, on the **Capabilities** tab, select **Microphone** and **Webcam**. Both capabilities are required to capture photos from the webcam.
 
-4. In `MainPage.xaml`, add this code to the root [Grid](https://msdn.microsoft.com/library/windows/apps/xaml/windows.ui.xaml.controls.grid.aspx) element:
+1. In `MainPage.xaml`, add this code to the root [Grid](https://msdn.microsoft.com/library/windows/apps/xaml/windows.ui.xaml.controls.grid.aspx) element:
 
    [!code-xml[wrl-media-capture#7](../windows/codesnippet/Xaml/walkthrough-creating-a-windows-store-app-using-wrl-and-media-foundation_7.xaml)]
 
-5. Use the following code to replace the contents of `MainPage.xaml.cs`.
+1. Use the following code to replace the contents of `MainPage.xaml.cs`:
 
    [!code-cs[wrl-media-capture#8](../windows/codesnippet/CSharp/walkthrough-creating-a-windows-store-app-using-wrl-and-media-foundation_8.cs)]
 
