Skip to content

Improve the log time function for 10 minute + renders #6207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 21, 2025

Conversation

tonynoce
Copy link
Contributor

While seeing the output on seconds is useful when they get longer ( which will start to happen more often since video models are here ) the total time gets a bit complicated to read on.

Specially for people leaving Comfy rendering overnight.

I hope this helps

@tonynoce
Copy link
Contributor Author

Sorry had to update the formatting since it gave and error, tested locally and worked :
image

@ltdrdata ltdrdata added the Good PR This PR looks good to go, it needs comfy's final review. label Dec 25, 2024
@christian-byrne
Copy link
Collaborator

Testing Methodology

  1. Fetched PR Improve the log time function for 10 minute + renders #6207
  2. Checked out PR branch locally (git fetch origin pull/6207/head:pr-6207)
  3. Extracted formatting logic into standalone module with testable functions
  4. Created comprehensive test suite covering:
    • Boundary conditions at 600s threshold
    • Time format conversions from 0s to 24h+
    • Edge cases (negative values, fractional seconds)
    • Variable type consistency
    • Performance benchmarking

Testing Results

All tests passed (8 tests, 0.009s)

Test Coverage

  • Boundary testing: Verified 600s threshold behavior
  • Format accuracy: Confirmed correct HH:MM:SS conversion
  • Edge cases: Negative values, fractional seconds, 24+ hour wraparound
  • Type handling: Variable reassignment doesn't affect downstream code
  • Performance: <0.01ms per format operation

Potential Issues Found

  1. Variable reassignment: Original code reassigns execution_time from float to string, but no downstream usage detected
  2. 24-hour wraparound: Times ≥24 hours wrap to 00:00:00 (e.g., 25h→01:00:00)
  3. No upper limit: Could display misleading times for extremely long renders

Overall Assessment

Low-risk, quality-of-life improvement. The PR correctly implements the feature with minimal code changes. The 24-hour wraparound is acceptable since renders rarely exceed this duration. The variable reassignment is contained within the logging block with no side effects.

@comfyanonymous comfyanonymous merged commit 31ca603 into comfyanonymous:master Jun 21, 2025
7 checks passed
@kevinpaik1
Copy link

Thank you for your contribution @tonynoce !

@tonynoce
Copy link
Contributor Author

Thank you for your contribution @tonynoce !

Thank u very much for the merge !

Lido95 pushed a commit to Lido95/ComfyUI1 that referenced this pull request Jun 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good PR This PR looks good to go, it needs comfy's final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants