fix: remove bzlmod pip.parse() annotations attribute (bazel-contrib#1808)

jbedard · aignas · web-flow · commit 1036a4d02bc7 · 2024-05-19T04:30:23.000Z
This change removes unused attributes from the `bzlmod` APIs cleaning up
the docs and src code.

---------

Co-authored-by: Ignas Anikevicius &lt;240938+aignas@users.noreply.github.com&gt;
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -42,6 +42,8 @@ A brief description of the categories of changes:
   also now handled correctly, stabilizing the implementation.
 * (gazelle) Fix Gazelle failing on Windows with
   "panic: runtime error: invalid memory address or nil pointer dereference"
+* (bzlmod) remove `pip.parse(annotations)` attribute as it is unused and has been
+  replaced by whl_modifications.
 
 ### Added
 * (rules) Precompiling Python source at build time is available. but is
diff --git a/python/private/bzlmod/pip.bzl b/python/private/bzlmod/pip.bzl
@@ -585,6 +585,9 @@ The labels are JSON config files describing the modifications.
     # don't allow users to override it.
     attrs.pop("repo_prefix")
 
+    # annotations has been replaced with whl_modifications in bzlmod
+    attrs.pop("annotations")
+
     return attrs
 
 def _whl_mod_attrs():
